Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tracking metrics setup for noisy benchmarks #2706

Closed
wants to merge 2 commits into from
Closed

Remove tracking metrics setup for noisy benchmarks #2706

wants to merge 2 commits into from

Commits on Aug 27, 2024

  1. Compute ground-truth optimization trace on BenchmarkProblem (facebook… 

    …#2704)

Summary:
Pull Request resolved: facebook#2704

This currently doesn't change behavior, but enables more flexibility by redefining `Problem.get_ground_truth_opt_trace` or `BenchmarkRunner.get_Y_true`. This is currently duplicative with the tracking metrics setup, which will be reaped in D61432000; these should be combined. This diff has both ways of computing the optimization trace running, along with an assertion that they give the same results.

Differential Revision: D61404056

Reviewed By: saitcakmak
    @esantorella @facebook-github-bot
    esantorella authored and facebook-github-bot committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    f54ae2e View commit details
    Browse the repository at this point in the history

  2. Remove tracking metrics setup for noisy benchmarks (facebook#2706) 

    Summary:
Pull Request resolved: facebook#2706

No longer needed after the changes in the previous diff.

Reviewed By: Balandat

Differential Revision: D61415525
    @esantorella @facebook-github-bot
    esantorella authored and facebook-github-bot committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    3c97e89 View commit details
    Browse the repository at this point in the history