Evaluate oracle at target task and fidelity #2727
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bjective_problem_from_botorch; support constrained MOO (facebook#2722) Summary: Pull Request resolved: facebook#2722 Context: These functions have a lot of overlapping functionality. Combining them makes it easier to extend their functionality (for example, by supporting constrained MOO). This PR: * Combines `create_single_problem_objective_from_botorch` and `create_multi_objective_problem_from_botorch` into `create_problem_from_botorch` * Reads `lower_is_better` off the test problem -- BoTorch test problems assume minimization unless `negate` is set to True -- instead of requiring the user to pass it (multi-objective problems used to always have lower_is_better=True, so this is more accurate and prevents mismatch) * Adds support for constrained MOO problems from Botorch * Remove stub for constrained MOO problem that only existed to test for an exception that is no longer raised Differential Revision: D61877865 Reviewed By: Balandat
Summary: `BenchmarkRunner.evaluate_oracle` now evaluates at the target task and fidelity. A weakness of this solution is that it requires passing the search space to the runner. Generally, there is too much information that must be on both the problem and the runner; this could be addressed by making the problem an attribute of the runner rather than the other way around. Reviewed By: sdaulton Differential Revision: D61884295
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61884295 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2727 +/- ##
==========================================
+ Coverage 95.40% 95.41% +0.01%
==========================================
Files 490 490
Lines 47828 47857 +29
==========================================
+ Hits 45631 45664 +33
+ Misses 2197 2193 -4 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in 9106255. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
BenchmarkRunner.evaluate_oraclenow evaluates at the target task and fidelity.A weakness of this solution is that it requires passing the search space to the runner. Generally, there is too much information that must be on both the problem and the runner; this could be addressed by making the problem an attribute of the runner rather than the other way around.
Reviewed By: sdaulton
Differential Revision: D61884295