fix(v2): fix useEffect infinite loop in blogOnly mode (#5097)

facebook · Jun 30, 2021 · 0f14421 · 0f14421
1 parent ab3821c
commit 0f14421
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/packages/docusaurus-plugin-content-docs/src/theme/hooks/useDocs.ts b/packages/docusaurus-plugin-content-docs/src/theme/hooks/useDocs.ts
@@ -24,11 +24,15 @@ import {
   GetActivePluginOptions,
 } from '../../client/docsClientUtils';
 
+// Important to use a constant object to avoid React useEffect executions etc...,
+// see https://github.com/facebook/docusaurus/issues/5089
+const StableEmptyObject = {};
+
 // Not using useAllPluginInstancesData() because in blog-only mode, docs hooks are still used by the theme
 // We need a fail-safe fallback when the docs plugin is not in use
 export const useAllDocsData = (): Record<string, GlobalPluginData> =>
   // useAllPluginInstancesData('docusaurus-plugin-content-docs');
-  useGlobalData()['docusaurus-plugin-content-docs'] ?? {};
+  useGlobalData()['docusaurus-plugin-content-docs'] ?? StableEmptyObject;
 
 export const useDocsData = (pluginId: string | undefined): GlobalPluginData =>
   usePluginData('docusaurus-plugin-content-docs', pluginId) as GlobalPluginData;