fix(v2): fix useEffect infinite loop in blogOnly mode #5097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ [V2] 🔨 Explore the source changes: 4e94caa 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60dc4b12ac9a71000762f65d 😎 Browse the preview: https://deploy-preview-5097--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5097--docusaurus-2.netlify.app/ |
|
Size Change: +4 B (0%) Total Size: 605 kB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Infinite loop produced because we use an "unstable" empty object fallback when there is no docs global data available => triggers downstream useEffect re-executions because the unstable object is used in dependency array
Issue can be reproduced in blogOnly mode
yarn workspace docusaurus-2-website start:blogOnlyFix #5089
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
none :( unfortunately this only happens on the client and the blogOnly CI action we have fails to catch this at build time
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)