-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[agp] Upgrade AGP, Kotlin, Gradle, maven publish plugin #982
Conversation
DATA_CLASS_GENERATE_VERSION=1.0.1 | ||
|
||
# Deps for publishing | ||
MAVEN_PUBLISH_PLUGIN=0.15.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, that's interesting. It seems though as if the old version is no longer able to publish anything now. It times out which looks like there are some problems with the TLS config. https://github.com/facebook/litho/actions/runs/8635428192/job/23756165085
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We were trying 0.22 and you're updating it to 0.28 so I think it may be worth checking if publishing with 0.28 isn't losing some of the classes. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! I can push a snapshot locally and if you or someone else could help validate if it's complete, that would be fab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we could try to use something like this maybe: https://github.com/JakeWharton/diffuse - build a local snapshot using old and new version of the maven publish plugin and compare the apks.
75fdefd
to
21b0428
Compare
Just a note: We may need to revert the AndroidManifest.xml changes because I think Buck builds may still depend on the attribute there. I'll focus on getting the Gradle build to work again first. |
1729233
to
2ed6b75
Compare
[agp] Upgrade AGP, Kotlin, Gradle, maven publish plugin
Stack created with Sapling. Best reviewed with ReviewStack.