-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[metro-visualizer] Add README and development script #292
Conversation
Codecov Report
@@ Coverage Diff @@
## master #292 +/- ##
=======================================
Coverage 85.86% 85.86%
=======================================
Files 143 143
Lines 4534 4534
Branches 709 709
=======================================
Hits 3893 3893
Misses 575 575
Partials 66 66 Continue to review full report at Codecov.
|
Thanks @simonpfish and sorry for the delay reviewing! I'm gonna import this into phabricator 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rafeca has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Hi, I realize this is still open. but I'm trying to get the visualizer to work and this is the only place I have found with any instructions. I'm stuck at a place where I think I need to see whether a specific package is being included in the bundle. When I follow the instructions here and visit
That's untrue however. React is definitely in my node_modules as it is a dep of every react-native related package. |
Hey! You might have to cd into the metro-visualizer package directory and run |
The idea is to run a simple metro server on the visualizer codebase that can be used to test the visualizer UI itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rebased and I'm gonna land it now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
…ation * upstream/master: (122 commits) Bump Metro to v0.53.0 Improve flow coverage in Metro Enable platform transforms for dev too, but keep it safe for MetroResolver Use function maps to symbolicate traces Move react-native-symbolicate to metro repo Migrated Metro from babel-jest to a custom transformer React sync for revisions f24a0da...8e25ed2 Revert D14168466: Perform security fixes Adds a missing dependency to metro Bumps antd to fix missing peerdeps Updates the package.json to match the Yarn output Improve prelude code Perform security fixes metro-buck: setup __DEV__ and other variables on the global object Add README and development script (facebook#292) Allow custom BABEL_ENV (facebook#364) Update siteConfig.js (facebook#327) docs: mention lerna in CONTRIBUTING.md (facebook#338) Revert D14024934: metro: keep track of significant dependencies ordering metro-buck: Hermes: no args to async wrapper if no prefetch ...
@simonpfish follow the README, can't make it work. check #373 |
Summary
A README was added to the
metro-visualizer
package with an overview of the tool and setup instructions.Additionally, a simple script that spawns a metro server for testing the visualizer was added to the package.
Note: I just completed the CLA for the first time.
Test plan
Read through the README. Run the development script from the
metro-visualizer
root folder and point the browser at http://localhost:8080/visualizer to make sure that the server is spawned correctly.