Allow custom BABEL_ENV #364
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
cpojer
approved these changes
Feb 25, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Codecov Report
@@ Coverage Diff @@
## master #364 +/- ##
======================================
Coverage 85.3% 85.3%
======================================
Files 173 173
Lines 5341 5341
Branches 814 814
======================================
Hits 4556 4556
Misses 698 698
Partials 87 87
Continue to review full report at Codecov.
|
thymikee
added a commit
to thymikee/metro
that referenced
this pull request
Mar 3, 2019
…ation * upstream/master: (122 commits) Bump Metro to v0.53.0 Improve flow coverage in Metro Enable platform transforms for dev too, but keep it safe for MetroResolver Use function maps to symbolicate traces Move react-native-symbolicate to metro repo Migrated Metro from babel-jest to a custom transformer React sync for revisions f24a0da...8e25ed2 Revert D14168466: Perform security fixes Adds a missing dependency to metro Bumps antd to fix missing peerdeps Updates the package.json to match the Yarn output Improve prelude code Perform security fixes metro-buck: setup __DEV__ and other variables on the global object Add README and development script (facebook#292) Allow custom BABEL_ENV (facebook#364) Update siteConfig.js (facebook#327) docs: mention lerna in CONTRIBUTING.md (facebook#338) Revert D14024934: metro: keep track of significant dependencies ordering metro-buck: Hermes: no args to async wrapper if no prefetch ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allows custom non-dev
BABEL_ENVs besides'production'. With respect to facebook/react-native#6351 (comment).Test plan
This change will break non-dev builds for people who for any reason has custom
BABEL_ENVset but expects it to behave like'production' (current behavior). Though it can be easily fixed either by renaming theirenvfromproductionto the value of customBABEL_ENV, or by changingBABEL_ENVfrom custom to'production'.Other than this unusual case, nothing should change.