Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Android Gradle plugin to 3.6.4 #28170

Closed
wants to merge 1 commit into from
Closed

Update Android Gradle plugin to 3.6.4 #28170

wants to merge 1 commit into from

Conversation

friederbluemle
Copy link
Contributor

@friederbluemle friederbluemle commented Feb 25, 2020 •
edited
Loading

Summary

Android Studio 3.6.3 is now available in the stable channel

https://androidstudio.googleblog.com/2020/04/android-studio-363-available.html

EDIT: Another patch update to 3.6.4 was released in July 2020:

This minor update supports compatibility with new default settings and features for package visibility in Android 11.

Details: https://developer.android.com/studio/releases/gradle-plugin#3-6-0

Changelog

[Android] [Changed] - Update Android Gradle plugin to 3.6.4

Test Plan

Build project

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 25, 2020
@react-native-bot react-native-bot added the Platform: Android Android applications. label Feb 25, 2020
@analysis-bot
Copy link

RNTester (Android/hermes/arm64-v8a): 3289088 bytes
RNTester (Android/hermes/armeabi-v7a): 3129344 bytes
RNTester (Android/hermes/x86): 3461120 bytes
RNTester (Android/hermes/x86_64): 3424256 bytes
RNTester (Android/jsc/arm64-v8a): 4444160 bytes
RNTester (Android/jsc/armeabi-v7a): 4265984 bytes
RNTester (Android/jsc/x86): 4358144 bytes
RNTester (Android/jsc/x86_64): 4644864 bytes

@analysis-bot
Copy link

RNTester.app (iOS): 10657792 bytes

dulmandakh
dulmandakh approved these changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@dulmandakh dulmandakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@friederbluemle friederbluemle changed the title Update Android Gradle plugin to 3.6.0 Update Android Gradle plugin to 3.6.1 Feb 28, 2020
@analysis-bot
Copy link

analysis-bot commented Mar 27, 2020 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,001,749 -2,798
android hermes armeabi-v7a 6,665,705 -2,805
android hermes x86 7,422,065 -2,799
android hermes x86_64 7,312,947 -2,798
android jsc arm64-v8a 9,161,574 -2,806
android jsc armeabi-v7a 8,817,666 -2,788
android jsc x86 9,009,982 -2,788
android jsc x86_64 9,587,060 -2,792

Base commit: 0056357

@analysis-bot
Copy link

analysis-bot commented Mar 27, 2020 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 0056357

@friederbluemle friederbluemle changed the title Update Android Gradle plugin to 3.6.1 Update Android Gradle plugin to 3.6.2 Apr 1, 2020
@friederbluemle
Copy link
Contributor Author

Rebased and updated to 3.6.2

@SaeedZhiany
Copy link
Contributor

@friederbluemle

Android Studio 3.6.3 has been released. please rebase and update this.

@friederbluemle
Copy link
Contributor Author

Thanks for the reminder @SaeedZhiany

@friederbluemle friederbluemle changed the title Update Android Gradle plugin to 3.6.2 Update Android Gradle plugin to 3.6.3 Apr 20, 2020
@SaeedZhiany
Copy link
Contributor

@friederbluemle

Android Studio 4.0.0 has been released. please rebase again. (or it's better to create another PR and check the possible break changes due to the major release?)

@friederbluemle friederbluemle mentioned this pull request May 31, 2020
Closed
@friederbluemle
Copy link
Contributor Author

Thanks @SaeedZhiany - Funny, I was actually looking into this right as you commented :D

It makes sense, I think 4.0.0 needs to be tested separately (#29013) - Meanwhile, I hope this PR here can be merged soon (has been approved a while ago). I just rebased it and resolved the conflict.

@friederbluemle friederbluemle mentioned this pull request Jul 12, 2020
Closed
@friederbluemle friederbluemle changed the title Update Android Gradle plugin to 3.6.3 Update Android Gradle plugin to 3.6.4 Aug 24, 2020
@friederbluemle
Copy link
Contributor Author

Rebased and updated to 3.6.4.

facebook-github-bot
facebook-github-bot reviewed Aug 26, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fkgozali has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@fkgozali
Copy link
Contributor

FYI, I updated the PR internally to also upgrade the ones used in https://github.com/facebook/react-native/tree/master/packages/react-native-codegen/android

@friederbluemle
Copy link
Contributor Author

Thanks @fkgozali

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @friederbluemle in cf8368f.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Aug 27, 2020
@friederbluemle friederbluemle deleted the update-gradle-plugin branch September 1, 2020 22:46
philippeauriach pushed a commit to philippeauriach/react-native that referenced this pull request May 5, 2021
@friederbluemle @philippeauriach
Update Android Gradle plugin to 3.6.4 (facebook#28170)
bcce6b2 
Summary:
Android Studio 3.6.3 is now available in the stable channel

https://androidstudio.googleblog.com/2020/04/android-studio-363-available.html

EDIT: Another patch update to `3.6.4` was released in July 2020:

> This minor update supports compatibility with new default settings and features for package visibility in Android 11.

Details: https://developer.android.com/studio/releases/gradle-plugin#3-6-0

## Changelog

[Android] [Changed] - Update Android Gradle plugin to 3.6.4

Pull Request resolved: facebook#28170

Test Plan: Build project

Reviewed By: mdvacca

Differential Revision: D23357163

Pulled By: fkgozali

fbshipit-source-id: 45f1bfc8a1b21e60c6da03e60e4fa3b1e30c221c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@dulmandakh dulmandakh dulmandakh approved these changes

@mdvacca mdvacca Awaiting requested review from mdvacca

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Platform: Android Android applications.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@friederbluemle @analysis-bot @SaeedZhiany @fkgozali @react-native-bot @dulmandakh @facebook-github-bot