Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump Android Gradle Plugin to 4.0.0 #29044

Closed
wants to merge 4 commits into from

Conversation

dulmandakh
Copy link
Contributor

@dulmandakh dulmandakh commented Jun 3, 2020

Summary

Bump Android Gradle Plugin to 4.0.1, part of Android Studio 4.0 release.

Changelog

[Android] [Changed] - Bump Android Gradle Plugin to 4.0.1

Test Plan

RNTester builds and runs as expected. And my app with RN 0.63 builds and runs as expected.

@react-native-bot react-native-bot added the Platform: Android Android applications. label Jun 3, 2020
@dulmandakh dulmandakh requested a review from mdvacca June 3, 2020 14:25
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. labels Jun 3, 2020
@analysis-bot
Copy link

analysis-bot commented Jun 3, 2020

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 18f7aba

@analysis-bot
Copy link

analysis-bot commented Jun 3, 2020

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,385,801 12,920
android hermes armeabi-v7a 7,009,021 9,068
android hermes x86 7,823,917 10,536
android hermes x86_64 7,717,499 12,568
android jsc arm64-v8a 9,528,006 11,448
android jsc armeabi-v7a 9,147,130 11,364
android jsc x86 9,392,682 10,044
android jsc x86_64 9,974,392 10,844

Base commit: 18f7aba

@dulmandakh dulmandakh requested a review from hramos June 4, 2020 04:58
@dulmandakh
Copy link
Contributor Author

@cpojer @hramos @mdvacca please merge 👍

@friederbluemle
Copy link
Contributor

friederbluemle commented Jul 12, 2020

The PR draft with an update to 4.0.0 4.0.1 is already open here: #29013

Can we merge #28170 with the update to 3.6.3 first please? It's been open since Feb 28, and has been rebased/updated multiple times. We should update in smaller incremental steps if possible.

@mdvacca
Copy link
Contributor

mdvacca commented Aug 26, 2020

CC @fkgozali

@fkgozali
Copy link
Contributor

Sorry for the delay. I need to merge the Gradle upgrade to 6.6 today, then I'll merge the android tools upgrade (this one, #28170, #29013)

@friederbluemle
Copy link
Contributor

Hi @fkgozali, thanks for the reply!

Just double checking, can you please confirm the order:

  1. Gradle Wrapper 6.6 Update Gradle Wrapper to 6.6 #29613 (Let me know if you want me to update this to 6.6.1, released yesterday)
  2. Android Gradle plugin 3.6.4 Update Android Gradle plugin to 3.6.4 #28170
  3. I'll rebase Update Android Gradle plugin to 4.0.1 #29013 for early testing with AGP 4+, and change it from draft to open PR
  4. Additional testing period before upgrading to AGP 4+ (I'd suggest at least a few weeks)

We can also close this PR (#29044), since AGP 4+ will be done in #29013

@fkgozali
Copy link
Contributor

fkgozali commented Aug 26, 2020

(Let me know if you want me to update this to 6.6.1, released yesterday)

No, as previously discussed, let's not always take the latest without discussion.

Re: 3/4, why not just go straight to 4.0.1 instead of 4.0.0, then 4.0.1?

EDIT:
I missed the last sentence:

We can also close this PR (#29044), since AGP 4+ will be done in #29013

So yeah let's track 4+ with #29013 and close this PR.

@friederbluemle
Copy link
Contributor

@mdvacca @fkgozali - Do you happen to have any information on the recent history destroying force pushes on the master branch? It happened (at least) twice already today. #29779

@rickhanlonii
Copy link
Member

The force pushes were necessary to fix the history, so the history was changed, not destroyed.

@friederbluemle
Copy link
Contributor

friederbluemle commented Aug 26, 2020

@rickhanlonii - Thanks for the reply! Maybe "destroyed" was not the right word, sorry about that. What I meant is that history was changed, i.e. the commits were overridden. Just curious: What kind of fix was necessary?
EDIT: Nevermind, I saw your comment in #29779 👍

@dulmandakh
Copy link
Contributor Author

@fkgozali let's merge this PR, and go ahead

@fkgozali
Copy link
Contributor

fkgozali commented Oct 1, 2020

@dulmandakh - but there's already #29013 right? Shouldn't we just merge that one instead?

@dulmandakh
Copy link
Contributor Author

I think we can settle on NDK version later on, and it might be better to move on with AGP.

@fkgozali
Copy link
Contributor

fkgozali commented Oct 1, 2020

I think we can settle on NDK version later on, and it might be better to move on with AGP.

Yeah but the other PR also upgrades to 4.0.1, which one should I merge for now? cc @friederbluemle

@dulmandakh dulmandakh closed this Oct 1, 2020
facebook-github-bot pushed a commit that referenced this pull request Oct 1, 2020
Summary:
This is a major version update that needs to be tested thoroughly.

Android Studio 4.0.1 is now available in the stable channel

https://androidstudio.googleblog.com/2020/05/android-studio-40-available-in-stable.html
https://developer.android.com/studio/releases/gradle-plugin#4.0.1

## Changelog

[Android] [Changed] - Update Android Gradle plugin to 4.0.1

Pull Request resolved: #29013

Test Plan:
Build project

Closes #29044

Reviewed By: shergin

Differential Revision: D24041233

Pulled By: fkgozali

fbshipit-source-id: 68ef0f313aa773866e65796e323ed0f19f41f834
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. Platform: Android Android applications.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants