Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move utilities out of react_native_pods - Part 2 #33982

Closed
wants to merge 2 commits into from
Closed

Move utilities out of react_native_pods - Part 2 #33982

wants to merge 2 commits into from

Commits on Jun 9, 2022

  1. Move cocoapods utilities to utils.rb - Part 1 (facebook#33978) 

    Summary:
Pull Request resolved: facebook#33978

This Diff moves part of the utilities from the `react_native_pods` file to a specific `utils.rb` file.

It adds tests for these utils and improve our test mocks.

The goal is to simplify the `react_native_pods.rb` so it's easier to work with it.

I decided to split this diff in 2 because it was becoming quite big.

## Changelog

[iOS][Changed] - Refactoring part of the react_native_pods.rb script

Differential Revision: D37004347

fbshipit-source-id: ecc1b1cb0825440e9e5ae5a92846bc8fe8602d99
    @facebook-github-bot
    Riccardo Cipolleschi authored and facebook-github-bot committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    109b828 View commit details
    Browse the repository at this point in the history

  2. Move utilities out of react_native_pods - Part 2 

    Summary:
This Diff moves another part of the utilities from the `react_native_pods` file to a specific `utils.rb` file.

It adds tests for these utils and improve our test mocks.

The goal is to simplify the `react_native_pods.rb` so it's easier to work with it.

I decided to split this diff in 2 because it was becoming quite big.

## Changelog

[iOS][Changed] - Refactoring part of the react_native_pods.rb script

Differential Revision: D37006265

fbshipit-source-id: 580152f6f3bc97c78e23d1004695c60a718c875c
    @facebook-github-bot
    Riccardo Cipolleschi authored and facebook-github-bot committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    41534d8 View commit details
    Browse the repository at this point in the history