Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React DevTools 4.18.0 -> 4.19.0 #22457

Closed
wants to merge 1 commit into from
Closed

React DevTools 4.18.0 -> 4.19.0 #22457

wants to merge 1 commit into from

Conversation

lunaruan
Copy link
Contributor

No description provided.

@facebook-github-bot facebook-github-bot added React Core Team Opened by a member of the React Core Team CLA Signed labels Sep 29, 2021
bvaughn
bvaughn suggested changes Sep 29, 2021
View reviewed changes
Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold off. The CHANGELOG looks weird.

packages/react-devtools/CHANGELOG.md
* Don't patch console during first render in strict mode ([lunaruan](https://github.com/lunaruan) in [#22308](https://github.com/facebook/react/pull/22308))
* Show which hook indicies changed when profiling for all builds ([bvaughn](https://github.com/bvaughn) in [#22365](https://github.com/facebook/react/pull/22365))
* Display actual ReactDOM API name in root type ([eps1lon](https://github.com/eps1lon) in [#22363](https://github.com/facebook/react/pull/22363))
* Add named hooks support to standalone and inline DevTools ([jstejada](https://github.com/jstejada) in [#22320](https://github.com/facebook/react/pull/22320) and [bvaughn](https://github.com/bvaughn) in [#22263](https://github.com/facebook/react/pull/22263))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are things I'd expect to see here that I don't...like showing errors and suspense names in the scheduling profiler.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I ran the release script locally, there were a lot more than 7 bullet points. The following should be added to this release:

Features

  • Scheduling Profiler: Show Suspense resource .displayName (USERNAME in #22451)
    • Scheduling Profiler marks should include thrown Errors (USERNAME in #22419)

Bugfix

  • DevTools encoding supports multibyte characters (e.g. "🟩") (USERNAME in #22424)

Performance

  • DevTools: Lazily parse indexed map sections (USERNAME in #22415)
  • DevTools: Hook names optimizations (USERNAME in #22403)
  • Replaced network.onRequestFinished() caching with network.getHAR() (USERNAME in #22285)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious, did you filter them out intentionally or did the sync script not log them for you?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I filtered the performance ones out but I didn't see the feature or bugfix ones :O

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't see them b'c you overlooked them or because the script didn't log them? If the latter, that's kind of concerning. (Can you do another test run from HEAD of main to confirm if the script is broken for you?)

In the short term, mind adding the ones above too? 🙇🏼

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh I see it's because I didn't pull all the changes from main before running the release 😅 my bad! Maybe the script should do a pull from main too or remind you to do it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh 😮 You must have been pretty behind?

We should probably kill this PR then and restart fresh.

@lunaruan lunaruan closed this Sep 29, 2021
@lunaruan lunaruan deleted the release branch September 29, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvaughn bvaughn bvaughn requested changes

@jstejada jstejada Awaiting requested review from jstejada

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lunaruan @bvaughn @facebook-github-bot