Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React DevTools 4.18.0 -> 4.19.0 #22457

Closed
wants to merge 1 commit into from
Closed

React DevTools 4.18.0 -> 4.19.0 #22457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-devtools-core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "react-devtools-core",
"version": "4.18.0",
"version": "4.19.0",
"description": "Use react-devtools outside of the browser",
"license": "MIT",
"main": "./dist/backend.js",
Expand Down
4 changes: 2 additions & 2 deletions packages/react-devtools-extensions/chrome/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
"manifest_version": 2,
"name": "React Developer Tools",
"description": "Adds React debugging tools to the Chrome Developer Tools.",
"version": "4.18.0",
"version_name": "4.18.0",
"version": "4.19.0",
"version_name": "4.19.0",
"minimum_chrome_version": "60",
"icons": {
"16": "icons/16-production.png",
Expand Down
4 changes: 2 additions & 2 deletions packages/react-devtools-extensions/edge/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
"manifest_version": 2,
"name": "React Developer Tools",
"description": "Adds React debugging tools to the Microsoft Edge Developer Tools.",
"version": "4.18.0",
"version_name": "4.18.0",
"version": "4.19.0",
"version_name": "4.19.0",
"minimum_chrome_version": "60",
"icons": {
"16": "icons/16-production.png",
Expand Down
2 changes: 1 addition & 1 deletion packages/react-devtools-extensions/firefox/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"manifest_version": 2,
"name": "React Developer Tools",
"description": "Adds React debugging tools to the Firefox Developer Tools.",
"version": "4.18.0",
"version": "4.19.0",
"applications": {
"gecko": {
"id": "@react-devtools",
Expand Down
2 changes: 1 addition & 1 deletion packages/react-devtools-inline/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "react-devtools-inline",
"version": "4.18.0",
"version": "4.19.0",
"description": "Embed react-devtools within a website",
"license": "MIT",
"main": "./dist/backend.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/react-devtools-scheduling-profiler/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"private": true,
"name": "react-devtools-scheduling-profiler",
"version": "4.18.0",
"version": "4.19.0",
"license": "MIT",
"dependencies": {
"@elg/speedscope": "1.9.0-a6f84db",
Expand Down
13 changes: 13 additions & 0 deletions packages/react-devtools/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,19 @@

<!-- RELEASE_SCRIPT_TOKEN -->

## 4.19.0 (September 28, 2021)

#### Features
* Don't patch console during first render in strict mode ([lunaruan](https://github.com/lunaruan) in [#22308](https://github.com/facebook/react/pull/22308))
* Show which hook indicies changed when profiling for all builds ([bvaughn](https://github.com/bvaughn) in [#22365](https://github.com/facebook/react/pull/22365))
* Display actual ReactDOM API name in root type ([eps1lon](https://github.com/eps1lon) in [#22363](https://github.com/facebook/react/pull/22363))
* Add named hooks support to standalone and inline DevTools ([jstejada](https://github.com/jstejada) in [#22320](https://github.com/facebook/react/pull/22320) and [bvaughn](https://github.com/bvaughn) in [#22263](https://github.com/facebook/react/pull/22263))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are things I'd expect to see here that I don't...like showing errors and suspense names in the scheduling profiler.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I ran the release script locally, there were a lot more than 7 bullet points. The following should be added to this release:

Features

  • Scheduling Profiler: Show Suspense resource .displayName (USERNAME in #22451)
    • Scheduling Profiler marks should include thrown Errors (USERNAME in #22419)

Bugfix

  • DevTools encoding supports multibyte characters (e.g. "🟩") (USERNAME in #22424)

Performance

  • DevTools: Lazily parse indexed map sections (USERNAME in #22415)
  • DevTools: Hook names optimizations (USERNAME in #22403)
  • Replaced network.onRequestFinished() caching with network.getHAR() (USERNAME in #22285)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious, did you filter them out intentionally or did the sync script not log them for you?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I filtered the performance ones out but I didn't see the feature or bugfix ones :O

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't see them b'c you overlooked them or because the script didn't log them? If the latter, that's kind of concerning. (Can you do another test run from HEAD of main to confirm if the script is broken for you?)

In the short term, mind adding the ones above too? 🙇🏼

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh I see it's because I didn't pull all the changes from main before running the release 😅 my bad! Maybe the script should do a pull from main too or remind you to do it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh 😮 You must have been pretty behind?

We should probably kill this PR then and restart fresh.

#### Bugfix
* Fix memory leak caused by not storing alternate Fiber pointer ([bvaughn](https://github.com/bvaughn) in [#22346](https://github.com/facebook/react/pull/22346))
* Fix call stack exceeded error in utfDecodeString() ([bvaughn](https://github.com/bvaughn) in [#22330](https://github.com/facebook/react/pull/22330))
* Fix runtime error when inspecting an element times out ([jstejada](https://github.com/jstejada) in [#22329](https://github.com/facebook/react/pull/22329))


## 4.18.0 (September 1, 2021)

#### Features
Expand Down
4 changes: 2 additions & 2 deletions packages/react-devtools/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "react-devtools",
"version": "4.18.0",
"version": "4.19.0",
"description": "Use react-devtools outside of the browser",
"license": "MIT",
"repository": {
Expand All @@ -27,7 +27,7 @@
"electron": "^11.1.0",
"ip": "^1.1.4",
"minimist": "^1.2.3",
"react-devtools-core": "4.18.0",
"react-devtools-core": "4.19.0",
"update-notifier": "^2.1.0"
}
}