Remove ReactDOM.render tests in ReactDOMConsoleErrorReporting-test

[jackpope]

Each it block here was duplicated to cover ReactDOM.render and ReactDOMClient.createRoot. Here we delete the ReactDOM.render coverage.

[rickhanlonii]

Should we wait to merge so there's not a span of commits missing the tests before it's removed? Probably doesn't matter, but I'm thinking about the case where we need to publish a security patch or something to 18 versions.

[react-sizebot]

Comparing: ec19db4...ad7e8db

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	176.24 kB	176.24 kB	=	54.88 kB	54.88 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	178.34 kB	178.34 kB	=	55.53 kB	55.53 kB
facebook-www/ReactDOM-prod.classic.js	=	571.94 kB	571.94 kB	=	100.56 kB	100.56 kB
facebook-www/ReactDOM-prod.modern.js	=	555.70 kB	555.70 kB	=	97.62 kB	97.62 kB
test_utils/ReactAllWarnings.js	Deleted	67.55 kB	0.00 kB	Deleted	16.54 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
test_utils/ReactAllWarnings.js	Deleted	67.55 kB	0.00 kB	Deleted	16.54 kB	0.00 kB

Generated by 🚫 dangerJS against ad7e8db

[kassens]

I think some of the tests specifically about ReactDOM.render we should keep until render is fully removes. Since we'll first do a feature flag for a while due to Meta's usage, we should retain some tests.

[jackpope]

Moved render based tests into Legacy test file which can be gated by feature flag

[rickhanlonii]

Nice plan

tests were put back