Convert ReactMultiChildReconcile to createRoot #28169

eps1lon · 2024-01-31T19:56:20Z

No description provided.

react-sizebot · 2024-01-31T20:00:19Z

Comparing: d29f7d9...4d14dbd

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	176.57 kB	176.57 kB	=	55.00 kB	55.00 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	178.69 kB	178.69 kB	=	55.64 kB	55.64 kB
facebook-www/ReactDOM-prod.classic.js	=	591.32 kB	591.32 kB	=	104.34 kB	104.34 kB
facebook-www/ReactDOM-prod.modern.js	=	575.08 kB	575.08 kB	=	101.43 kB	101.43 kB
test_utils/ReactAllWarnings.js	Deleted	67.56 kB	0.00 kB	Deleted	16.59 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
test_utils/ReactAllWarnings.js	Deleted	67.56 kB	0.00 kB	Deleted	16.59 kB	0.00 kB

Generated by 🚫 dangerJS against 4d14dbd

gaearon · 2024-02-03T17:47:15Z

packages/react-dom/src/__tests__/ReactMultiChildReconcile-test.js

+        prepareChildren={prepareChildren}
+        ref={current => {
+          if (parentInstance === undefined) {
+            parentInstance = current;


Nit: can this assignment be unconditional?

Either I make this conditional or I have to repeat the ref for each render call.

In other tests we sometimes went with assigning ref in cDM instead to not have to repeat the ref prop but that isn't possible here since FriendsStatusDisplay is out of scope.

The current approach is closest to the original test and similar to the oter cDM patterns so I'm leaving it.

gaearon · 2024-02-03T17:47:58Z

packages/react-dom/src/__tests__/ReactMultiChildReconcile-test.js

    let statusDisplays = parentInstance.getStatusDisplays();
    const startingInternalState = statusDisplays.jcw.getInternalState();

-    // Now remove the child.


Nit: are these comments outdated? I find them somewhat helpful (assuming they're right)

Removed by accident. Will restore.

DiffTrain build for commit 214fe84.

Convert ReactMultiChildReconcile to createRoot

da98603

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jan 31, 2024

eps1lon marked this pull request as ready for review January 31, 2024 20:06

gaearon approved these changes Feb 3, 2024

View reviewed changes

Restore comments

4d14dbd

eps1lon merged commit 214fe84 into facebook:main Feb 4, 2024
36 checks passed

eps1lon deleted the test/create-root/ReactMultiChildReconcile branch February 4, 2024 14:47

gnoff mentioned this pull request Feb 5, 2024

Update React from 60a927d04 to 2bc7d336a vercel/next.js#61522

Merged

ztanner mentioned this pull request Mar 19, 2024

(backport) Update React from 60a927d04 to 14898b6a9 vercel/next.js#63442

Closed

EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024

Convert ReactMultiChildReconcile to createRoot (facebook#28169)

619e393

bigfootjon pushed a commit that referenced this pull request Apr 18, 2024

Convert ReactMultiChildReconcile to createRoot (#28169)

63b1bc0

DiffTrain build for commit 214fe84.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert ReactMultiChildReconcile to createRoot #28169

Convert ReactMultiChildReconcile to createRoot #28169

eps1lon commented Jan 31, 2024

react-sizebot commented Jan 31, 2024 •

edited

Loading

gaearon Feb 3, 2024

eps1lon Feb 4, 2024

gaearon Feb 3, 2024

eps1lon Feb 4, 2024

Convert ReactMultiChildReconcile to createRoot #28169

Convert ReactMultiChildReconcile to createRoot #28169

Conversation

eps1lon commented Jan 31, 2024

react-sizebot commented Jan 31, 2024 • edited Loading

Critical size changes

Significant size changes

gaearon Feb 3, 2024

Choose a reason for hiding this comment

eps1lon Feb 4, 2024

Choose a reason for hiding this comment

gaearon Feb 3, 2024

Choose a reason for hiding this comment

eps1lon Feb 4, 2024

Choose a reason for hiding this comment

react-sizebot commented Jan 31, 2024 •

edited

Loading