Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RTR from StrictEffectsMode-test #28387

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

jackpope
Copy link
Contributor

Summary

Cleaning up internal usage of ReactTestRenderer

How did you test this change?

yarn test packages/react-reconciler/src/__tests__/StrictEffectsMode-test.js

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 20, 2024
@react-sizebot
Copy link

react-sizebot commented Feb 20, 2024

Comparing: a515d75...68223e5

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 176.85 kB 176.85 kB = 55.14 kB 55.14 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 178.85 kB 178.85 kB = 55.72 kB 55.72 kB
facebook-www/ReactDOM-prod.classic.js = 591.91 kB 591.91 kB = 104.47 kB 104.47 kB
facebook-www/ReactDOM-prod.modern.js = 575.20 kB 575.20 kB = 101.47 kB 101.47 kB
test_utils/ReactAllWarnings.js Deleted 66.90 kB 0.00 kB Deleted 16.40 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 66.90 kB 0.00 kB Deleted 16.40 kB 0.00 kB

Generated by 🚫 dangerJS against 68223e5

Copy link
Collaborator

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for the reconciler it makes more sense to use the noop-renderer which we use in all the other reconciler tests as well unless they're DOM specific or internal tests.

@jackpope
Copy link
Contributor Author

@eps1lon Thanks for the callout. Updated to use ReactNoop

@jackpope jackpope merged commit 59fe6c3 into facebook:main Feb 21, 2024
36 checks passed
@jackpope jackpope deleted the remove-rtr-usage-4 branch February 21, 2024 20:17
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
## Summary

Cleaning up internal usage of ReactTestRenderer

## How did you test this change?

`yarn test
packages/react-reconciler/src/__tests__/StrictEffectsMode-test.js`
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
## Summary

Cleaning up internal usage of ReactTestRenderer

## How did you test this change?

`yarn test
packages/react-reconciler/src/__tests__/StrictEffectsMode-test.js`

DiffTrain build for commit 59fe6c3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants