Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enableComponentStackLocations to ReactNativeInternalFeatureFlags libdef #28424

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

yungsters
Copy link
Contributor

Summary

Fixing something I accidentally broke this in 25dbb35.

How did you test this change?

Ran the following successfully:

$ yarn flow dom-node

@rickhanlonii rickhanlonii merged commit aaa4acb into facebook:main Feb 22, 2024
2 of 23 checks passed
@yungsters yungsters deleted the fix-flow branch February 22, 2024 23:58
@react-sizebot
Copy link

Comparing: 25dbb35...ec780c6

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 176.86 kB 176.86 kB = 55.14 kB 55.14 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 179.01 kB 179.01 kB = 55.78 kB 55.78 kB
facebook-www/ReactDOM-prod.classic.js = 592.40 kB 592.40 kB = 104.67 kB 104.67 kB
facebook-www/ReactDOM-prod.modern.js = 575.68 kB 575.68 kB = 101.66 kB 101.66 kB
test_utils/ReactAllWarnings.js Deleted 66.50 kB 0.00 kB Deleted 16.27 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 66.50 kB 0.00 kB Deleted 16.27 kB 0.00 kB

Generated by 🚫 dangerJS against ec780c6

EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
…gs` libdef (facebook#28424)

## Summary

Fixing something I accidentally broke this in
facebook@25dbb35.

## How did you test this change?

Ran the following successfully:

```
$ yarn flow dom-node
```
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
…gs` libdef (#28424)

## Summary

Fixing something I accidentally broke this in
25dbb35.

## How did you test this change?

Ran the following successfully:

```
$ yarn flow dom-node
```

DiffTrain build for commit aaa4acb.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants