[compiler] Propogate effects stored in object props #30457
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we propogated only effects of functions/methods to the outer function context. In this PR, we have extended the propagation of function/method effects to include those captured in object expressions. This change is generally a no-op, as the functions defined within the same context as the object expression already had their effects captured. This new infra allows us to delete certain effects, such as global mutation, for object expressions that are passed down as props. [ghstack-poisoned]
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Jul 25, 2024
facebook-github-bot
added
CLA Signed
React Core Team
Previously, we propogated only effects of functions/methods to the outer function context. In this PR, we have extended the propagation of function/method effects to include those captured in object expressions. This change is generally a no-op, as the functions defined within the same context as the object expression already had their effects captured. This new infra allows us to delete certain effects, such as global mutation, for object expressions that are passed down as props. [ghstack-poisoned]
poteto
approved these changes
Jul 25, 2024
| const functionEffect = this.reference(place, effectKind, reason); | ||
| if (functionEffect !== null) { | ||
| functionEffects.push(functionEffect); | ||
| } | ||
| } | ||
|
|
||
| propogateEffect( |
There was a problem hiding this comment.
Suggested change
| propogateEffect( | |
| propagateEffect( |
very minor spelling nit
There was a problem hiding this comment.
A couple questions:
- should we do the same for array expressions?
- just double-checking, is this safe in the case of the object being mutated? I guess it should be since we are eagerly evaluating the effects of the properties and propagating them to the parent function, so it doesn’t matter what happens to the object. If anything the main risk is of false positives where we eagerly propagate a function effect bc of a function property that is assigned, even though it’s subsequently deleted or reassigned from the object before it could be called.
It also seems like this wouldn’t handle the case where a mutating function is attached to the object after creation.
ie const obj = {mutatingFunction} will be allowed but const obj ={}; obj.mutatingFunction = mutatingFunction won’t, even if the objects are otherwise used the same way.
I think it still makes sense to land this as-is (maybe add support for array expressions) but just some things to consider.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Previously, we propogated only effects of functions/methods to the outer
function context.
In this PR, we have extended the propagation of function/method effects
to include those captured in object expressions. This change is
generally a no-op, as the functions defined within the same context as
the object expression already had their effects captured.
This new infra allows us to delete certain effects, such as global
mutation, for object expressions that are passed down as props.