Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[compiler] Propogate effects stored in object props #30457

Closed
wants to merge 2 commits into from
Closed

[compiler] Propogate effects stored in object props #30457

wants to merge 2 commits into from

Commits on Jul 25, 2024

  1. [compiler] Propogate effects stored in object props 

    Previously, we propogated only effects of functions/methods to the outer
function context.

In this PR, we have extended the propagation of function/method effects
to include those captured in object expressions. This change is
generally a no-op, as the functions defined within the same context as
the object expression already had their effects captured.

This new infra allows us to delete certain effects, such as global
mutation, for object expressions that are passed down as props.

[ghstack-poisoned]
    @gsathya
    gsathya committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    c9043f5 View commit details
    Browse the repository at this point in the history

  2. Update on "[compiler] Propogate effects stored in object props" 

    Previously, we propogated only effects of functions/methods to the outer
function context.

In this PR, we have extended the propagation of function/method effects
to include those captured in object expressions. This change is
generally a no-op, as the functions defined within the same context as
the object expression already had their effects captured.

This new infra allows us to delete certain effects, such as global
mutation, for object expressions that are passed down as props.

[ghstack-poisoned]
    @gsathya
    gsathya committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    f7443ac View commit details
    Browse the repository at this point in the history