Skip to content

Commit

Permalink
Fix CI failures (#4816)
Browse files Browse the repository at this point in the history
Summary:
Two fixes for CI
- **Yarn**: Required updating the minimum node version to 18+ after installing `testing-library/react`/`testing-library/dom` in b221f96
  - I updated `14` with `18` and `16` with `20`
- **Cargo**: Required a `cargo build` after adding `relay-codemod` in bddf8a4

Pull Request resolved: #4816

Reviewed By: kassens

Differential Revision: D64118554

Pulled By: jackpope

fbshipit-source-id: 833f17a54d941c11ca433e4c2984a3037ec68a5d
  • Loading branch information
Jack Pope authored and facebook-github-bot committed Oct 10, 2024
1 parent dead15d commit 8cb943e
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 8 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
with:
node-version: 16.x
node-version: 20.x
cache: 'yarn'
- name: Install dependencies
run: yarn install --frozen-lockfile --ignore-scripts
Expand All @@ -34,7 +34,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [14.x, 16.x]
node-version: [18.x, 20.x]
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
Expand All @@ -53,7 +53,7 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
with:
node-version: 16.x
node-version: 20.x
cache: 'yarn'
- name: Install dependencies
run: yarn install --frozen-lockfile --ignore-scripts
Expand All @@ -71,7 +71,7 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
with:
node-version: 16.x
node-version: 20.x
cache: 'yarn'
- name: Install dependencies
run: yarn install --frozen-lockfile --ignore-scripts
Expand Down Expand Up @@ -184,7 +184,7 @@ jobs:
- uses: actions/setup-node@v2
if: github.event_name == 'push' && github.repository == 'facebook/relay' && github.ref == 'refs/heads/main'
with:
node-version: 16.x
node-version: 20.x
cache: 'yarn'
- name: Install dependencies
if: github.event_name == 'push' && github.repository == 'facebook/relay' && github.ref == 'refs/heads/main'
Expand Down Expand Up @@ -224,7 +224,7 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
with:
node-version: 14.x
node-version: 18.x
registry-url: https://registry.npmjs.org/
cache: 'yarn'
- name: Install dependencies
Expand Down
14 changes: 14 additions & 0 deletions compiler/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,8 @@
},
"private": true,
"devEngines": {
"node": ">=4.x",
"npm": ">=2.x"
"node": ">=18.x",
"npm": ">=8.x"
},
"prettier": {
"arrowParens": "avoid",
Expand Down

0 comments on commit 8cb943e

Please sign in to comment.