Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI failures #4816

Closed
wants to merge 2 commits into from
Closed

Fix CI failures #4816

wants to merge 2 commits into from

Conversation

jackpope
Copy link

@jackpope jackpope commented Oct 9, 2024 •
edited
Loading

Two fixes for CI

  • Yarn: Required updating the minimum node version to 18+ after installing @testing-library/react/@testing-library/dom in b221f96
    • I updated 14 with 18 and 16 with 20
  • Cargo: Required a cargo build after adding relay-codemod in bddf8a4

@jackpope jackpope changed the title Update minimum node version to 18 Fix CI failures Oct 9, 2024
@jackpope jackpope marked this pull request as ready for review October 9, 2024 13:50
@facebook-github-bot
Copy link
Contributor

@tyao1 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@jackpope merged this pull request in 8cb943e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyao1 tyao1 tyao1 approved these changes

Assignees
No one assigned
Labels
CLA Signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jackpope @facebook-github-bot @tyao1