[modern] relay-compiler: createRefetchContainer expects a second argument of fragment definitions.

[alex-wilmer]

This is the result of running "relay": "relay-compiler --src . --schema schema.graphql"

This isn't a "relay" compliant schema, but is that the problem?

type Link {
  id: ID
  url: String
  description: String
  tags: [Tag]
}

type Mutation {
  createLink(url: String!, description: String, tags: [TagInput]): Link
  createTag(name: String!): Tag
}

type Query {
  links(id: ID): [Link]
  tags(id: ID): [Tag]
}

type Tag {
  id: ID
  name: String
  links: [Link]
}

input TagInput {
  name: String!
}

error:

Error: FindGraphQLTags: `createRefetchContainer` expects a second argument of fragment definitions.
    at invariant (/Users/awilmer/Projects/venn/node_modules/relay-compiler/bin/relay-compiler:4401:12)
    at CallExpression (/Users/awilmer/Projects/venn/node_modules/relay-compiler/bin/relay-compiler:4270:82)
    at visit (/Users/awilmer/Projects/venn/node_modules/relay-compiler/bin/relay-compiler:4408:6)
    at traverse (/Users/awilmer/Projects/venn/node_modules/relay-compiler/bin/relay-compiler:4421:8)
    at visit (/Users/awilmer/Projects/venn/node_modules/relay-compiler/bin/relay-compiler:4411:4)
    at /Users/awilmer/Projects/venn/node_modules/relay-compiler/bin/relay-compiler:4425:12
    at Array.forEach (native)
    at traverse (/Users/awilmer/Projects/venn/node_modules/relay-compiler/bin/relay-compiler:4423:13)
    at visit (/Users/awilmer/Projects/venn/node_modules/relay-compiler/bin/relay-compiler:4411:4)
    at /Users/awilmer/Projects/venn/node_modules/relay-compiler/bin/relay-compiler:4425:12

repo: https://github.com/alex-wilmer/venn

[josephsavona]

I don't see where in the repo you linked you have the createRefetchContainer call, can you provide a specific link? Note that the function signature is createRefetchContainer(component, fragments, query): the error suggests the second parameter is missing.

[alex-wilmer]

I haven't written any front end code yet.. I'm just following the instructions in the "Get Started" section

https://facebook.github.io/relay/docs/relay-modern.html#getting-started

What i've done so far:

• Create a graphql schema
• install the packages listed in Getting Started
• use printSchema to generate schema.graphql
• run the relay compiler script <----- this throws the error

[josephsavona]

Super weird. Does the string createRefetchContainer appear anywhere? Can you narrow down which src file is causing this error?

[alangenfeld]

I am guessing it is picking up a createRefetchContainer from inside node_modules. We should probably blacklist that directory but in the mean time you can point --src at a directory of just your js files.

[alex-wilmer]

@alangenfeld indeed it was picking up node_modules. Is this something actionable I can make a PR for?

it was a little confusing error message even though it technically makes sense now

[alangenfeld]

here is where we blacklist other directories
https://github.com/facebook/relay/blob/master/packages/relay-compiler/bin/RelayCompilerBin.js#L40-L42

[alex-wilmer]

hmm so this might be too explicit for all uses of a node_modules folder. we use node_modules for our own modules as well.

something like:

node_modules/ <-- npm packages
modules/
  node_modules/ <-- project modules