Ignore node_modules while compiling queries #1686
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact [email protected] if you have any questions. |
|
CLA signed 👍 |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
@leebyron has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Thanks! |
Summary: It would be nice to be a little more flexible with the search paths for `relay-compiler`. As of #1686 `relay-compiler` ignores node_modules. We have several Relay apps that share common components through node_modules and need a way to tell the compiler which ones to search. This change will let us add several more specific search paths and override the setting to ignore node_modules. I was careful to do this in a way that is not a breaking change. Closes #1921 Reviewed By: JenniferWang Differential Revision: D5410197 Pulled By: kassens fbshipit-source-id: e4fd90cb57be985458342ee9b35972982d5c462b
This prevents nonintuitive errors like
'createRefetchContainer' expects a second argument of fragment definitions.when using the project root (including node_modules) as source directory.(fixes #1635)