This repository has been archived by the owner on Jan 7, 2022. It is now read-only.
Allow LogDevice to build without Submodules #71
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
There was a problem hiding this comment.
@calebmarchent has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
calebmarchent
force-pushed
the
build_external_with_fbcode_builder
branch
from
4e63a54
to
bb1c134
Compare
There was a problem hiding this comment.
@calebmarchent has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
calebmarchent
force-pushed
the
build_external_with_fbcode_builder
branch
2 times, most recently
from
3393466
to
cd33171
Compare
There was a problem hiding this comment.
@calebmarchent has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
calebmarchent
force-pushed
the
build_external_with_fbcode_builder
branch
from
cd33171
to
bd3b05d
Compare
There was a problem hiding this comment.
@calebmarchent has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
As a step in the plan to migrate LogDevice to using fbcode_builder as the primary build method, allow LogDevice to build without submodules. In place of the self compiled modules, the CMake scripts will look in the system (or provided prefix locations) and use precompiled modules there. Users can then use fbcode_builder to ensure those required modules are built and available. * Use new 'folly_test_util' library rather than referencing sources directly * Build thrift and its requirements outselves as we don't want rsocket which is in default config
calebmarchent
force-pushed
the
build_external_with_fbcode_builder
branch
from
bd3b05d
to
324a6d8
Compare
There was a problem hiding this comment.
@calebmarchent has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
to facebook/openr
that referenced
this pull request
Mar 27, 2019
Summary: As a step in the plan to migrate LogDevice to using fbcode_builder as the primary build method, allow LogDevice to build without submodules. In place of the self compiled modules, the CMake scripts will look in the system (or provided prefix locations) and use precompiled modules there. Users can then use fbcode_builder to ensure those required modules are built and available. * Use new 'folly_test_util' library rather than referencing sources directly Pull Request resolved: facebookarchive/LogDevice#71 Reviewed By: AhmedSoliman Differential Revision: D14578119 Pulled By: calebmarchent fbshipit-source-id: 36400d41d3f1906919706d20d0fb53195fec2e63
facebook-github-bot
pushed a commit
to facebook/fbthrift
that referenced
this pull request
Mar 27, 2019
Summary: As a step in the plan to migrate LogDevice to using fbcode_builder as the primary build method, allow LogDevice to build without submodules. In place of the self compiled modules, the CMake scripts will look in the system (or provided prefix locations) and use precompiled modules there. Users can then use fbcode_builder to ensure those required modules are built and available. * Use new 'folly_test_util' library rather than referencing sources directly Pull Request resolved: facebookarchive/LogDevice#71 Reviewed By: AhmedSoliman Differential Revision: D14578119 Pulled By: calebmarchent fbshipit-source-id: 36400d41d3f1906919706d20d0fb53195fec2e63
facebook-github-bot
pushed a commit
to facebookarchive/bistro
that referenced
this pull request
Mar 27, 2019
Summary: As a step in the plan to migrate LogDevice to using fbcode_builder as the primary build method, allow LogDevice to build without submodules. In place of the self compiled modules, the CMake scripts will look in the system (or provided prefix locations) and use precompiled modules there. Users can then use fbcode_builder to ensure those required modules are built and available. * Use new 'folly_test_util' library rather than referencing sources directly Pull Request resolved: facebookarchive/LogDevice#71 Reviewed By: AhmedSoliman Differential Revision: D14578119 Pulled By: calebmarchent fbshipit-source-id: 36400d41d3f1906919706d20d0fb53195fec2e63
facebook-github-bot
pushed a commit
to facebookarchive/fbzmq
that referenced
this pull request
Mar 27, 2019
Summary: As a step in the plan to migrate LogDevice to using fbcode_builder as the primary build method, allow LogDevice to build without submodules. In place of the self compiled modules, the CMake scripts will look in the system (or provided prefix locations) and use precompiled modules there. Users can then use fbcode_builder to ensure those required modules are built and available. * Use new 'folly_test_util' library rather than referencing sources directly Pull Request resolved: facebookarchive/LogDevice#71 Reviewed By: AhmedSoliman Differential Revision: D14578119 Pulled By: calebmarchent fbshipit-source-id: 36400d41d3f1906919706d20d0fb53195fec2e63
facebook-github-bot
pushed a commit
to facebook/watchman
that referenced
this pull request
Mar 27, 2019
Summary: As a step in the plan to migrate LogDevice to using fbcode_builder as the primary build method, allow LogDevice to build without submodules. In place of the self compiled modules, the CMake scripts will look in the system (or provided prefix locations) and use precompiled modules there. Users can then use fbcode_builder to ensure those required modules are built and available. * Use new 'folly_test_util' library rather than referencing sources directly Pull Request resolved: facebookarchive/LogDevice#71 Reviewed By: AhmedSoliman Differential Revision: D14578119 Pulled By: calebmarchent fbshipit-source-id: 36400d41d3f1906919706d20d0fb53195fec2e63
facebook-github-bot
pushed a commit
to facebook/wangle
that referenced
this pull request
Mar 27, 2019
Summary: As a step in the plan to migrate LogDevice to using fbcode_builder as the primary build method, allow LogDevice to build without submodules. In place of the self compiled modules, the CMake scripts will look in the system (or provided prefix locations) and use precompiled modules there. Users can then use fbcode_builder to ensure those required modules are built and available. * Use new 'folly_test_util' library rather than referencing sources directly Pull Request resolved: facebookarchive/LogDevice#71 Reviewed By: AhmedSoliman Differential Revision: D14578119 Pulled By: calebmarchent fbshipit-source-id: 36400d41d3f1906919706d20d0fb53195fec2e63
facebook-github-bot
pushed a commit
to facebook/folly
that referenced
this pull request
Mar 27, 2019
Summary: As a step in the plan to migrate LogDevice to using fbcode_builder as the primary build method, allow LogDevice to build without submodules. In place of the self compiled modules, the CMake scripts will look in the system (or provided prefix locations) and use precompiled modules there. Users can then use fbcode_builder to ensure those required modules are built and available. * Use new 'folly_test_util' library rather than referencing sources directly Pull Request resolved: facebookarchive/LogDevice#71 Reviewed By: AhmedSoliman Differential Revision: D14578119 Pulled By: calebmarchent fbshipit-source-id: 36400d41d3f1906919706d20d0fb53195fec2e63
facebook-github-bot
pushed a commit
to facebookincubator/fizz
that referenced
this pull request
Mar 27, 2019
Summary: As a step in the plan to migrate LogDevice to using fbcode_builder as the primary build method, allow LogDevice to build without submodules. In place of the self compiled modules, the CMake scripts will look in the system (or provided prefix locations) and use precompiled modules there. Users can then use fbcode_builder to ensure those required modules are built and available. * Use new 'folly_test_util' library rather than referencing sources directly Pull Request resolved: facebookarchive/LogDevice#71 Reviewed By: AhmedSoliman Differential Revision: D14578119 Pulled By: calebmarchent fbshipit-source-id: 36400d41d3f1906919706d20d0fb53195fec2e63
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 27, 2019
Summary: As a step in the plan to migrate LogDevice to using fbcode_builder as the primary build method, allow LogDevice to build without submodules. In place of the self compiled modules, the CMake scripts will look in the system (or provided prefix locations) and use precompiled modules there. Users can then use fbcode_builder to ensure those required modules are built and available. * Use new 'folly_test_util' library rather than referencing sources directly Pull Request resolved: #71 Reviewed By: AhmedSoliman Differential Revision: D14578119 Pulled By: calebmarchent fbshipit-source-id: 36400d41d3f1906919706d20d0fb53195fec2e63
facebook-github-bot
pushed a commit
to rsocket/rsocket-cpp
that referenced
this pull request
Mar 29, 2019
Summary: As a step in the plan to migrate LogDevice to using fbcode_builder as the primary build method, allow LogDevice to build without submodules. In place of the self compiled modules, the CMake scripts will look in the system (or provided prefix locations) and use precompiled modules there. Users can then use fbcode_builder to ensure those required modules are built and available. * Use new 'folly_test_util' library rather than referencing sources directly Pull Request resolved: facebookarchive/LogDevice#71 Reviewed By: AhmedSoliman Differential Revision: D14578119 Pulled By: calebmarchent fbshipit-source-id: 36400d41d3f1906919706d20d0fb53195fec2e63
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a step in the plan to migrate LogDevice to using fbcode_builder as
the primary build method, allow LogDevice to build without submodules.
In place of the self compiled modules, the CMake scripts will look in
the system (or provided prefix locations) and use precompiled modules
there. Users can then use fbcode_builder to ensure those required
modules are built and available.
directly