Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Remove unnecessary stepCancel #212

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions pkg/runner/test_runner.go
Original file line number Diff line number Diff line change
Expand Up @@ -213,12 +213,11 @@ func (tr *TestRunner) run(

// Wait for step runners and readers to exit.
if err := tr.waitStepRunners(ctx); err != nil {
tr.log.Errorf("step runner error: %q, canceling", err)
stepCancel()
if runErr == nil {
runErr = err
}
}

// There will be no more results, reel in all the target runners (if any).
tr.log.Debugf("waiting for target runners to finish")
targetCancel()
Expand Down