Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Remove unnecessary stepCancel #212

Closed
wants to merge 1 commit into from
Closed

Remove unnecessary stepCancel #212

wants to merge 1 commit into from

Conversation

rojer
Copy link
Contributor

@rojer rojer commented Jan 19, 2021

No description provided.

@codecov
Copy link

codecov bot commented Jan 19, 2021

Codecov Report

Merging #212 (4a53855) into master (11388b8) will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #212      +/-   ##
==========================================
- Coverage   61.73%   61.61%   -0.12%     
==========================================
  Files          83       83              
  Lines        4056     4054       -2     
==========================================
- Hits         2504     2498       -6     
- Misses       1233     1235       +2     
- Partials      319      321       +2     
Flag Coverage Δ
integration 56.54% <ø> (-0.10%) ⬇️
integration_storage 100.00% <ø> (ø)
unittests 50.73% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/runner/test_runner.go 90.75% <ø> (-0.76%) ⬇️
pkg/cerrors/cerrors.go 12.50% <0.00%> (-12.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11388b8...4a53855. Read the comment docs.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 19, 2021
@facebook-github-bot
Copy link

Hi @rojer!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@marcoguerri
Copy link
Contributor

marcoguerri commented Jan 26, 2021

This looks good (there is a header missing somewhere that we need to fix that is failing the SLA check), but I could not find a way to comment on code which is outside of the scope of this diff and I wanted to leave additional comments to the test runner, so I went back and commented in #208. Please have a look when you have a moment.

@rojer9-fb
Copy link
Contributor

will reopen with my facebook account

@rojer9-fb rojer9-fb closed this Jan 26, 2021
@rojer9-fb
Copy link
Contributor

#219

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants