Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update versioning with cmake #2727

Merged
merged 3 commits into from
Aug 11, 2023
Merged

Conversation

leogr
Copy link
Member

@leogr leogr commented Aug 10, 2023

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area tests

/area proposals

/area CI

What this PR does / why we need it:

See falcosecurity/libs#1294

Special notes for your reviewer:

/milestone 0.36.0

Does this PR introduce a user-facing change?:

NONE

@leogr leogr force-pushed the build/update-versioning-with-cmake branch from 5e1f1a9 to 4f57f57 Compare August 11, 2023 13:43
@leogr leogr changed the title wip: build: update versioning with cmake build: update versioning with cmake Aug 11, 2023
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Aug 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, jasondellaluce, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit a2b21fa into master Aug 11, 2023
14 checks passed
@poiana poiana deleted the build/update-versioning-with-cmake branch August 11, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants