refactor: versioning with cmake #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
kind/design
dco-signoff: yes
kind/documentation
leogr
force-pushed
the
refactor/versioning-with-cmake
branch
from
48365b1
to
ca42019
Compare
leogr
changed the title
Signed-off-by: Leonardo Grasso <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
…elease branch Signed-off-by: Leonardo Grasso <[email protected]>
leogr
force-pushed
the
refactor/versioning-with-cmake
branch
from
b25bb00
to
e4ee582
Compare
jasondellaluce
approved these changes
Aug 11, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, jasondellaluce, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind design
/kind documentation
/kind feature
Any specific area of the project related to this PR?
Does this PR require a change in the driver versions?
No.
What this PR does / why we need it:
This PR improves the build system's ability to automatically construct version numbers string, in particular for development builds. The new implementation ensures that the resulting strings are consistent with the SemVer specification and can be ordered in the proper way. More detail about the revised convention and implementation can be found in the updated README.md by this PR. As a bonus point, this PR also removes ad unnecessary dependency in the spirit of streamlining our 3rd-party dependencies.
Once this PR gets merged and libs bumped in Falco, the new cmake module and the revised convention can also be used by Falco.
/milestone 0.13.0
Does this PR introduce a user-facing change?: