fix(falco_metrics): fix prometheus metrics to be compliant with best practices #3337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
size/S
release-note
size/M
and removed
do-not-merge/release-note-label-needed
size/S
labels
Signed-off-by: Leonardo Di Giovanna <[email protected]>
Signed-off-by: Leonardo Di Giovanna <[email protected]>
Using JSON as value prevents any meaningful aggregation for the stats. Splitting these information into multiple labels can drastically increase the number of dimensions, as the number of interfaces and addresses can be high in some environment. Moreover, these information are not currently refreshed, even if they can frequently change. Given these reasons, remove ifinfo_json from stats and metrics. Signed-off-by: Leonardo Di Giovanna <[email protected]>
Signed-off-by: Leonardo Di Giovanna <[email protected]>
ekoops
force-pushed
the
fix-prometheus-metrics
branch
from
c06522b
to
d6fe0d9
Compare
ekoops
changed the title
|
/milestone 0.39.0 Thanks for this PR! LGTM! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ekoops, FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: ce54e16497dabc89176e08357104dc92d9b7a24a
|
leogr
approved these changes
Sep 23, 2024
This was referenced Sep 24, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
This PR introduces the following changes:
tagslabel infalcosecurity_falco_sha256_config_files_infoandfalcosecurity_falco_sha256_rules_files_infogauges into multipletag_<tag>="true"labelsWhich issue(s) this PR fixes:
Fixes #3336
Special notes for your reviewer:
Does this PR introduce a user-facing change?: