Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(falco_metrics): fix prometheus metrics to be compliant with best practices #3337

Merged
merged 4 commits into from
Sep 23, 2024
Merged

fix(falco_metrics): fix prometheus metrics to be compliant with best practices #3337

merged 4 commits into from
Sep 23, 2024

Commits on Sep 23, 2024

  1. fix(falco_metrics)!: split tags label into multiple tag_ labels 

    Signed-off-by: Leonardo Di Giovanna <[email protected]>
    @ekoops
    ekoops committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    5e5e04e View commit details
    Browse the repository at this point in the history

  2. fix(falco_metrics)!: use full name for configs and rules files 

    Signed-off-by: Leonardo Di Giovanna <[email protected]>
    @ekoops
    ekoops committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    7e07643 View commit details
    Browse the repository at this point in the history

  3. fix(falco_metrics): remove ifinfo_json stat/metric 

    Using JSON as value prevents any meaningful aggregation for the stats.
Splitting these information into multiple labels can drastically
increase the number of dimensions, as the number of interfaces and
addresses can be high in some environment. Moreover, these information
are not currently refreshed, even if they can frequently change. Given
these reasons, remove ifinfo_json from stats and metrics.

Signed-off-by: Leonardo Di Giovanna <[email protected]>
    @ekoops
    ekoops committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    90a5fd6 View commit details
    Browse the repository at this point in the history

  4. cleanup(falco_metrics): remove unused falco_utils import 

    Signed-off-by: Leonardo Di Giovanna <[email protected]>
    @ekoops
    ekoops committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    d6fe0d9 View commit details
    Browse the repository at this point in the history