Support ERB syntax in old Ruby versions #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please add this change to the changelog? Looking good 👍 |
done! |
arielj
commented
Jun 9, 2023
| @@ -49,7 +53,16 @@ def compatibility(rails_version: nil, include_rails_gems: nil) | |||
| <%= incompatible_gems.length.to_s.red %> gems incompatible with Rails <%= rails_version %> | |||
| ERB | |||
|
|
|||
| puts ERB.new(template, trim_mode: "-").result(binding) | |||
| erb_version = ERB.version | |||
| if erb_version =~ /erb.rb \[([\d\.]+) .*\]/ | |||
There was a problem hiding this comment.
in older erb versions, the version string was something like erb [2.2.0 2019-10-04] instead of just the version, but it changed in newer versions to just 4.0.0
JuanVqz
approved these changes
Jun 9, 2023
|
@arielj could you please rebase the main branch? now the CI should work as expected 👍 |
mateusdeap
approved these changes
Jun 12, 2023
JuanVqz
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The bundler report compatibility command didn't work in old ERB version. This PR adds a test that exercises that line and also the fix calling
ERB.newwith different arguments depending on the ERB version.Motivation and Context
This issue #99
I think this is the same issue #96
How Has This Been Tested?
Added automated tests, without this change it fails in Ruby 2.3
I will abide by the code of conduct