Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ruby 2.2 setup in github action #101

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Fix Ruby 2.2 setup in github action #101

merged 1 commit into from
Jun 9, 2023

Conversation

arielj
Copy link

@arielj arielj commented Jun 7, 2023

When the tests start to run, the Ruby 2.2 tests have a bug that makes it fail and that produces a cancellation of all the other jobs in that matrix.

Seems to be a known issue and this PR adds the proposed workaround from this bug report ruby/setup-ruby#496 (comment) running 2.2 and older in a previous version of Ubuntu instead of Ubuntu latest

You can see in the other 2 latest PRs that it was failing for 2.2 always, and I ran all the versions manually for #100 and 2.2 keeps failing

image
image

@arielj arielj requested a review from a team as a code owner June 7, 2023 14:51
@arielj arielj requested review from mateusdeap and removed request for a team June 7, 2023 14:51
Copy link
Member

@JuanVqz JuanVqz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thank you for taking the time to debug it and solve it, is this worth it to add it in the change log? If so, please do it otherwise, I already approved it

@JuanVqz JuanVqz merged commit dee37d2 into main Jun 9, 2023
@JuanVqz JuanVqz deleted the fix-ruby2.2-ci branch June 9, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants