-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing historical retrieval assertion #1622
Conversation
Signed-off-by: Willem Pienaar <[email protected]>
Signed-off-by: Willem Pienaar <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1622 +/- ##
==========================================
+ Coverage 77.84% 83.64% +5.79%
==========================================
Files 66 67 +1
Lines 5688 5814 +126
==========================================
+ Hits 4428 4863 +435
+ Misses 1260 951 -309
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Fix failing historical retrieval assertion Signed-off-by: Willem Pienaar <[email protected]> * Ensure comments are accurate Signed-off-by: Willem Pienaar <[email protected]>
Signed-off-by: Willem Pienaar [email protected]
What this PR does / why we need it:
Fixes failing e2e test
Does this PR introduce a user-facing change?: