Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing historical retrieval assertion #1622

Merged
merged 2 commits into from
Jun 7, 2021
Merged

Fix failing historical retrieval assertion #1622

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ec6589
Fix failing historical retrieval assertion
woop Jun 7, 2021
5cdea7f
Ensure comments are accurate
woop Jun 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions sdk/python/tests/test_historical_retrieval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,12 +465,13 @@ def test_historical_features_from_bigquery_sources(
],
)

# Make sure that custom dataset name is being used from the offline_store config
if provider_type == "gcp_custom_offline_config":
# Make sure that custom dataset name is being used from the offline_store config
assertpy.assert_that(job_from_df.query).contains("foo.entity_df")
else:
# If the custom dataset name isn't provided in the config, use default `feast` name
assertpy.assert_that(job_from_df.query).contains("feast.entity_df")
assertpy.assert_that(job_from_df.query).contains(
f"{bigquery_dataset}.entity_df"
)

actual_df_from_df_entities = job_from_df.to_df()

Expand Down