Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor providers to remove duplicate implementations #1876

Merged
merged 8 commits into from
Sep 17, 2021

Conversation

achals
Copy link
Member

@achals achals commented Sep 16, 2021

Signed-off-by: Achal Shah [email protected]

What this PR does / why we need it:

Currently, the AWS, GCP and Local providers have the exact same implementation - and the implementation only defers actual business logic of setting up infrastructure and materializing data to the offline/online store interfaces.

This is confusing for users, and is unnecessary code to maintain. Instead, this PR refactors the implementations into a single implementation, with a dummy subclass for the 3 existing providers for backwards compatibility.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

none

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2021

Codecov Report

Merging #1876 (6ab8c3f) into master (8a49a65) will decrease coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1876      +/-   ##
==========================================
- Coverage   83.96%   83.81%   -0.16%     
==========================================
  Files          95       96       +1     
  Lines        7392     7316      -76     
==========================================
- Hits         6207     6132      -75     
+ Misses       1185     1184       -1     
Flag Coverage Δ
integrationtests 74.48% <100.00%> (-0.25%) ⬇️
unittests 62.35% <100.00%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/aws.py 81.66% <100.00%> (-7.23%) ⬇️
sdk/python/feast/infra/gcp.py 87.50% <100.00%> (-5.29%) ⬇️
sdk/python/feast/infra/local.py 86.36% <100.00%> (-6.14%) ⬇️
sdk/python/feast/infra/passthrough_provider.py 100.00% <100.00%> (ø)
sdk/python/feast/infra/provider.py 90.43% <100.00%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a49a65...6ab8c3f. Read the comment docs.

@woop
Copy link
Member

woop commented Sep 16, 2021

Would you mind adding a description to your PR please?

Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@feast-ci-bot feast-ci-bot removed the lgtm label Sep 17, 2021
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
@achals
Copy link
Member Author

achals commented Sep 17, 2021

Would you mind adding a description to your PR please?

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants