Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of _convert_arrow_to_proto #1984

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Improve performance of _convert_arrow_to_proto #1984

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions sdk/python/feast/infra/provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,27 +304,28 @@ def _coerce_datetime(ts):
else:
return ts

column_names_idx = {k: i for i, k in enumerate(table.column_names)}
for row in zip(*table.to_pydict().values()):
entity_key = EntityKeyProto()
for join_key in join_keys:
entity_key.join_keys.append(join_key)
idx = table.column_names.index(join_key)
idx = column_names_idx[join_key]
value = python_value_to_proto_value(row[idx])
entity_key.entity_values.append(value)
feature_dict = {}
for feature in feature_view.features:
idx = table.column_names.index(feature.name)
idx = column_names_idx[feature.name]
value = python_value_to_proto_value(row[idx], feature.dtype)
feature_dict[feature.name] = value
event_timestamp_idx = table.column_names.index(
event_timestamp_idx = column_names_idx[
feature_view.batch_source.event_timestamp_column
)
]
event_timestamp = _coerce_datetime(row[event_timestamp_idx])

if feature_view.batch_source.created_timestamp_column:
created_timestamp_idx = table.column_names.index(
created_timestamp_idx = column_names_idx[
feature_view.batch_source.created_timestamp_column
)
]
created_timestamp = _coerce_datetime(row[created_timestamp_idx])
else:
created_timestamp = None
Expand Down