Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Clean up dependencies in setup.py #4004

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

tokoko
Copy link
Collaborator

@tokoko tokoko commented Mar 9, 2024

What this PR does / why we need it:

  • removed unused dependency on avro
  • removed unused dependency on proto-plus (it's still pulled in through transitive dependency on gcp libraries)
  • moved httpx to ci extra as it's only used by fastapi testing utilities
  • docs and dev extras are same as ci, there are no longer any reasons at this point for them to be different, problematic mysql dependency was fixed a while ago

Also fixes #4000

@franciscojavierarceo
Copy link
Member

@tokoko looks like you need to resolve some conflicts here

@tokoko
Copy link
Collaborator Author

tokoko commented Mar 17, 2024

I'm waiting for Lokesh's PR dropping 3.8 to merge first

@tokoko tokoko reopened this Mar 19, 2024
@tokoko
Copy link
Collaborator Author

tokoko commented Mar 19, 2024

@franciscojavierarceo this is good to go now

@jeremyary jeremyary merged commit 7b93c3d into feast-dev:master Mar 19, 2024
20 checks passed
@tokoko tokoko deleted the setup-cleanup branch March 19, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the behavior of install-python-ci-dependencies
3 participants