Skip to content

Commit

Permalink
Draft changes to add remote online store to feast.
Browse files Browse the repository at this point in the history
Signed-off-by: Lokesh Rangineni <[email protected]>

Adding the integration test and remote online creator class so that it will fit into existing integration testing framework.

Signed-off-by: Lokesh Rangineni <[email protected]>

Fix after rebase

Signed-off-by: Lokesh Rangineni <[email protected]>

Removing the RemoteOnlineStoreCreator and adding custom integration test case. Incorporating the code review comments.

Signed-off-by: Lokesh Rangineni <[email protected]>

reformatting the code, removing unnecessary braces.

Signed-off-by: Lokesh Rangineni <[email protected]>

Trying to fix the errors reported in make lint-python

Signed-off-by: Lokesh Rangineni <[email protected]>

Ran the command make format-python and trying to see if it fixes the lint errors.

Signed-off-by: Lokesh Rangineni <[email protected]>

increasing the server start timeout to see if it fixes the integration test cases.

Signed-off-by: Lokesh Rangineni <[email protected]>

checking changes after make format-python

Signed-off-by: Lokesh Rangineni <[email protected]>

trying to see if this fixes the PR integrationt test failure.
Signed-off-by: Lokesh Rangineni <[email protected]>

Signed-off-by: Lokesh Rangineni <[email protected]>

checking in the changes for make format-python

Signed-off-by: Lokesh Rangineni <[email protected]>

Upgrading python version to 3.11, adding support for 3.11 as well.

Signed-off-by: Lokesh Rangineni <[email protected]>

chore: Bump macOS runners to macos-13 (feast-dev#4152)

bump macos runner to 13

Signed-off-by: tokoko <[email protected]>

Signed-off-by: Lokesh Rangineni <[email protected]>

chore: Use pixi to lock python dependencies in a single command (feast-dev#4114)

use pixi to lock python dependencies in a single command

Signed-off-by: tokoko <[email protected]>

Signed-off-by: Lokesh Rangineni <[email protected]>

feat: List all feature views (feast-dev#4256)

* feature: Adding type to base feature view

Signed-off-by: Francisco Javier Arceo <[email protected]>

* fixed linter

Signed-off-by: Francisco Javier Arceo <[email protected]>

* fixed type and meta

Signed-off-by: Francisco Javier Arceo <[email protected]>

* adding new listing

Signed-off-by: Francisco Javier Arceo <[email protected]>

* updated

Signed-off-by: Francisco Javier Arceo <[email protected]>

* cleaning up changes

Signed-off-by: Francisco Javier Arceo <[email protected]>

* reverting FV proto

Signed-off-by: Francisco Javier Arceo <[email protected]>

* doing simple way

Signed-off-by: Francisco Javier Arceo <[email protected]>

* added a test

Signed-off-by: Francisco Javier Arceo <[email protected]>

* updated to add warnings

Signed-off-by: Francisco Javier Arceo <[email protected]>

---------

Signed-off-by: Francisco Javier Arceo <[email protected]>
feat: Adding vector search for sqlite (feast-dev#4176)

* feat: Adding vector search for sqlite

Signed-off-by: Francisco Javier Arceo <[email protected]>

* adding the sqlite_vss dependency

Signed-off-by: Francisco Javier Arceo <[email protected]>

* linter

Signed-off-by: Francisco Javier Arceo <[email protected]>

* latest progress

Signed-off-by: Francisco Javier Arceo <[email protected]>

* uploading latest progress

Signed-off-by: Francisco Javier Arceo <[email protected]>

* updated function

Signed-off-by: Francisco Javier Arceo <[email protected]>

* adding configuration

Signed-off-by: Francisco Javier Arceo <[email protected]>

* adding current progress

Signed-off-by: Francisco Javier Arceo <[email protected]>

* updating requirements files

Signed-off-by: Francisco Javier Arceo <[email protected]>

* moving to sqlite-vec

Signed-off-by: Francisco Javier Arceo <[email protected]>

* updating sqlite.py

Signed-off-by: Francisco Javier Arceo <[email protected]>

* checking in progress

Signed-off-by: Francisco Javier Arceo <[email protected]>

* updated test type

Signed-off-by: Francisco Javier Arceo <[email protected]>

* got the initialization working, nice

Signed-off-by: Francisco Javier Arceo <[email protected]>

* checking in progress from last night

Signed-off-by: Francisco Javier Arceo <[email protected]>

* removing unnecessary stuff

Signed-off-by: Francisco Javier Arceo <[email protected]>

* fixing merge conflicts

Signed-off-by: Francisco Javier Arceo <[email protected]>

* removing files changed accidentally]

Signed-off-by: Francisco Javier Arceo <[email protected]>

* uploading current progress...things run but need to update the virtual table insertion

Signed-off-by: Francisco Javier Arceo <[email protected]>

* linted

Signed-off-by: Francisco Javier Arceo <[email protected]>

* adding working notes

Signed-off-by: Francisco Javier Arceo <[email protected]>

* found a bug, original feature_store.py was only grabbing first feature view, adjusted

Signed-off-by: Francisco Javier Arceo <[email protected]>

* cant use a string have to verify it is a proper FeatureView object

Signed-off-by: Francisco Javier Arceo <[email protected]>

* updated got it working, need to fix some other stuff still

Signed-off-by: Francisco Javier Arceo <[email protected]>

* working

Signed-off-by: Francisco Javier Arceo <[email protected]>

* linter

Signed-off-by: Francisco Javier Arceo <[email protected]>

* fixing some type issues

Signed-off-by: Francisco Javier Arceo <[email protected]>

* fixed typing and lint issues

Signed-off-by: Francisco Javier Arceo <[email protected]>

* updated dependencies

Signed-off-by: Francisco Javier Arceo <[email protected]>

* fix for pixi and updating requirements

Signed-off-by: Francisco Javier Arceo <[email protected]>

* fixed type

Signed-off-by: Francisco Javier Arceo <[email protected]>

* linter

Signed-off-by: Francisco Javier Arceo <[email protected]>

* testing sqlite_vec import

Signed-off-by: Francisco Javier Arceo <[email protected]>

* adding minimal example test

Signed-off-by: Francisco Javier Arceo <[email protected]>

* lint

Signed-off-by: Francisco Javier Arceo <[email protected]>

* testing raw sqlite

Signed-off-by: Francisco Javier Arceo <[email protected]>

* Printing package version

* printing version

Signed-off-by: Francisco Javier Arceo <[email protected]>

* updated requirements

* rebuilding requirments

Signed-off-by: Francisco Javier Arceo <[email protected]>

* only going to run this on 3.10 for now

Signed-off-by: Francisco Javier Arceo <[email protected]>

* updated docs for sqlite caveats

Signed-off-by: Francisco Javier Arceo <[email protected]>

* adding reason

Signed-off-by: Francisco Javier Arceo <[email protected]>

* skipping

Signed-off-by: Francisco Javier Arceo <[email protected]>

* updated tests

Signed-off-by: Francisco Javier Arceo <[email protected]>

* removing print

Signed-off-by: Francisco Javier Arceo <[email protected]>

* added method call

Signed-off-by: Francisco Javier Arceo <[email protected]>

* added prubt

Signed-off-by: Francisco Javier Arceo <[email protected]>

* added print

Signed-off-by: Francisco Javier Arceo <[email protected]>

* removing print

Signed-off-by: Francisco Javier Arceo <[email protected]>

* adding check in sqlite

Signed-off-by: Francisco Javier Arceo <[email protected]>

* missed an =

Signed-off-by: Francisco Javier Arceo <[email protected]>

* still running on 3.11

Signed-off-by: Francisco Javier Arceo <[email protected]>

* typo

Signed-off-by: Francisco Javier Arceo <[email protected]>

* fix

Signed-off-by: Francisco Javier Arceo <[email protected]>

* fix

Signed-off-by: Francisco Javier Arceo <[email protected]>

* updated setup and docs

Signed-off-by: Francisco Javier Arceo <[email protected]>

* renamed things

Signed-off-by: Francisco Javier Arceo <[email protected]>

---------

Signed-off-by: Francisco Javier Arceo <[email protected]>
squashing the last 15 commits to one.

Merge branch 'master' into feature/adding-remote-onlinestore-rebase

Adding documentation and incorporating code review comment.

Signed-off-by: Lokesh Rangineni <[email protected]>

Adding documentation and incorporating code review comment.

Signed-off-by: Lokesh Rangineni <[email protected]>

Merge remote-tracking branch 'fork/feature/adding-remote-onlinestore-rebase' into feature/adding-remote-onlinestore-rebase

Signed-off-by: Lokesh Rangineni <[email protected]>
  • Loading branch information
lokeshrangineni committed Jun 13, 2024
1 parent dd84f45 commit 85f26bd
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 11 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/pr_integration_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: [ "3.9", "3.10", "3.11" ]
python-version: [ "3.11" ]
os: [ ubuntu-latest ]
env:
OS: ${{ matrix.os }}
Expand Down
6 changes: 0 additions & 6 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,6 @@ lock-python-dependencies-all:
pixi run --environment py311 --manifest-path infra/scripts/pixi/pixi.toml "uv pip compile --system --no-strip-extras setup.py --output-file sdk/python/requirements/py3.11-requirements.txt"
pixi run --environment py311 --manifest-path infra/scripts/pixi/pixi.toml "uv pip compile --system --no-strip-extras setup.py --extra ci --output-file sdk/python/requirements/py3.11-ci-requirements.txt"

lock-python-dependencies-all:
pixi run --environment py39 --manifest-path infra/scripts/pixi/pixi.toml "python -m piptools compile -U --output-file sdk/python/requirements/py3.9-requirements.txt"
pixi run --environment py39 --manifest-path infra/scripts/pixi/pixi.toml "python -m piptools compile -U --extra ci --output-file sdk/python/requirements/py3.9-ci-requirements.txt"
pixi run --environment py310 --manifest-path infra/scripts/pixi/pixi.toml "python -m piptools compile -U --output-file sdk/python/requirements/py3.10-requirements.txt"
pixi run --environment py310 --manifest-path infra/scripts/pixi/pixi.toml "python -m piptools compile -U --extra ci --output-file sdk/python/requirements/py3.10-ci-requirements.txt"

benchmark-python:
IS_TEST=True python -m pytest --integration --benchmark --benchmark-autosave --benchmark-save-data sdk/python/tests

Expand Down
8 changes: 6 additions & 2 deletions infra/scripts/pixi/pixi.toml
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,18 @@ platforms = ["linux-64", "osx-arm64"]
[tasks]

[dependencies]
pip-tools = ">=7.4.1,<7.5"
uv = ">=0.1.39,<0.2"

[feature.py39.dependencies]
python = "~=3.9.0"

[feature.py310.dependencies]
python = "~=3.10.0"

[feature.py311.dependencies]
python = "~=3.11.0"

[environments]
py39 = ["py39"]
py310 = ["py310"]
py310 = ["py310"]
py311 = ["py311"]
10 changes: 9 additions & 1 deletion sdk/python/tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,15 @@ def simple_dataset_2() -> pd.DataFrame:

def start_test_local_server(repo_path: str, port: int):
fs = FeatureStore(repo_path)
fs.serve("localhost", port, no_access_log=True)
fs.serve(
host="localhost",
port=port,
no_access_log=True,
keep_alive_timeout=30,
type_="http",
workers=1,
registry_ttl_sec=30,
)


@pytest.fixture
Expand Down
1 change: 0 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@
"uvicorn[standard]>=0.14.0,<1",
"gunicorn; platform_system != 'Windows'",
"dask[dataframe]>=2024.4.2",
"bowler", # Needed for automatic repo upgrades
]

GCP_REQUIRED = [
Expand Down

0 comments on commit 85f26bd

Please sign in to comment.