fix: Initial commit targetting grpc registry server #4458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniele Martinoli <[email protected]>
dmartinol
changed the title
dmartinol
changed the title
tmihalac
reviewed
Aug 28, 2024
…east-dev#4465) introduced base class FeastError for all Feast exceptions, with initial methods to map the grpc and HTTP status code Signed-off-by: Daniele Martinoli <[email protected]>
Signed-off-by: Daniele Martinoli <[email protected]>
Signed-off-by: Daniele Martinoli <[email protected]>
|
@tokoko @tmihalac @lokeshrangineni ready for review now |
|
@dmartinol I think you need to rebase |
tokoko
reviewed
Aug 29, 2024
Signed-off-by: Daniele Martinoli <[email protected]>
Signed-off-by: Daniele Martinoli <[email protected]>
Signed-off-by: Daniele Martinoli <[email protected]>
|
@tokoko is this a known IT failure reason? |
|
I'll force a retry, but that looks like a genuine credentials error |
tokoko
reviewed
Aug 30, 2024
sdk/python/feast/errors.py
Outdated
|
|
||
| @staticmethod | ||
| def from_error_detail(detail: str) -> Optional["FeastError"]: | ||
| import importlib |
There was a problem hiding this comment.
These are standard lib libraries, why not import top-level?
Signed-off-by: Daniele Martinoli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Intercept registry server failures and adds an additional message to the response with the failure status and details.
The proxy client then rebuilds the original error from the status data.
Which issue(s) this PR fixes:
Partially fixes #4392 for Registry Server
Misc
Need to add some UT/IT to prove the effectivness