refactor: Introduced base class FeastError for all Feast exceptions #4465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al methods to map the grpc and HTTP status code Signed-off-by: Daniele Martinoli <[email protected]>
tokoko
approved these changes
Aug 29, 2024
dmartinol
added a commit
to dmartinol/feast
that referenced
this pull request
Aug 29, 2024
…east-dev#4465) introduced base class FeastError for all Feast exceptions, with initial methods to map the grpc and HTTP status code Signed-off-by: Daniele Martinoli <[email protected]>
lokeshrangineni
pushed a commit
to lokeshrangineni/feast
that referenced
this pull request
Aug 29, 2024
…east-dev#4465) introduced base class FeastError for all Feast exceptions, with initial methods to map the grpc and HTTP status code Signed-off-by: Daniele Martinoli <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]>
tokoko
pushed a commit
that referenced
this pull request
Aug 30, 2024
* initial commit targetting grpc registry server Signed-off-by: Daniele Martinoli <[email protected]> * refactor: Introduced base class FeastError for all Feast exceptions (#4465) introduced base class FeastError for all Feast exceptions, with initial methods to map the grpc and HTTP status code Signed-off-by: Daniele Martinoli <[email protected]> * initial commit targetting grpc registry server Signed-off-by: Daniele Martinoli <[email protected]> * fixed merge error Signed-off-by: Daniele Martinoli <[email protected]> * initial commit targetting grpc registry server Signed-off-by: Daniele Martinoli <[email protected]> * fixed merge error Signed-off-by: Daniele Martinoli <[email protected]> * integrated comment Signed-off-by: Daniele Martinoli <[email protected]> * moved imports as per comment Signed-off-by: Daniele Martinoli <[email protected]> --------- Signed-off-by: Daniele Martinoli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
FeastPermissionErroras a customPermissionErrorFeastObjectNotFoundExceptionandFeastPermissionErrorWhich issue(s) this PR fixes:
In preparation for #4392