Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Group E Transaction Screen (JF Transfers) #233

Closed
AureliaKhorsand opened this issue Apr 19, 2022 · 12 comments
Closed

Create Group E Transaction Screen (JF Transfers) #233

AureliaKhorsand opened this issue Apr 19, 2022 · 12 comments
Assignees

Comments

@AureliaKhorsand
Copy link
Contributor

AureliaKhorsand commented Apr 19, 2022

Business Reason

As a Committee Administrator, I will be able to enter a transaction for "JF Transfers" on Schedule A of a Form 3X report so that I can accurately report on my committee's transactions.

NOTE: This is a "parent" transaction that will typically have associated sub-transactions.

Acceptance Criteria

Given I am a Committee Administrator editing an open Form 3X report
When I Add a new transaction
And click(open) on the "Transfers" accordion link
Then I can enter a transaction with the type "JF Transfers"
And I will be required to enter the following information (unless otherwise noted):

Contributor

  • CONTRIBUTOR TYPE (Read-only)
    Field description in API: ENTITY TYPE
    Data field: COMMITTEE
  • COMMITTEE NAME (A/N-200, Required)
    Field description in API: CONTRIBUTOR ORGANIZATION NAME
    Data field: textbox
  • CONTRIBUTOR FEC ID (A/N-9, Required)
    Field description in API: DONOR COMMITTEE FEC ID
    Data field: textbox
    With the ID in the following format: "CXXXXXXXX" where X is a numeric value (C, then 8 numbers)
    FEC ID IS A STOP-GAP UNTIL THE LOOKUP IS IN PLACE

Address

  • STREET ADDRESS (A/N-34, Required)
    Field description in API: CONTRIBUTOR STREET 1
    Data field: textbox
  • APARTMENT, SUITE, ETC. (A/N-34, Optional)
    Field description in API: CONTRIBUTOR STREET 2
    Data field: textbox
  • CITY (A/N-30, Required)
    Field description in API: CONTRIBUTOR CITY
    Data field: textbox
  • STATE/PROVINCE (ALPHA-2, Required)
    Field description in API: CONTRIBUTOR STATE
    Data field: Dropdown
    Dropdown options: States without military
    https://docs.google.com/spreadsheets/d/17YmnaZgqvFOUyv4-Qknd8ikHe8o9LoDb/edit#gid=494776297
  • ZIP/POSTAL CODE (A/N-9, Required)
    Field description in API: CONTRIBUTOR ZIP
    Data field: textbox

Contribution

  • DATE RECEIVED (NUM-8…YYYYMMDD, Required)
    Field description in API: CONTRIBUTION DATE
    Data field: Date picker
  • MEMO ITEM (A/N-1, Optional)
    Field description in API: MEMO CODE
    Data field: Checkbox
  • CONTRIBUTION AMOUNT (AMT-12, Required)
    Field description in API: CONTRIBUTION AMOUNT
    Data field: textbox
  • CONTRIBUTION AGGREGATE (AMT-12, Required)
    Field description in API: CONTRIBUTION AGGREGATE
    Data field: textbox (FOR NOW it will say $0.00)
    This is automatically calculated as an aggregate of this contributor's contributions YTD, in any reports, in chronological order)

Additional information

  • CONTRIBUTION PURPOSE DESCRIPTION (Read-only)
    Field description in API: RECEIPT DESCRIPTION
    Data field: multi-line textbox that MUST SAY "Transfer of JF Proceeds"
  • NOTE OR MEMO TEXT (A/N-100, Optional)
    Field description in API: MEMO TEXT/DESCRIPTION
    Data field: multi-line textbox

Then I will be able to:

Dev Note

See Schedule A spec here.

See JF Transfers spec here.

Group E - JF Transfers.png

Group E - JF Transfer - Errors.png

Group E - JF Transfer - Required Fields.png

QA Notes

null

DEV Notes

null

Design

null

@AureliaKhorsand
Copy link
Contributor Author

AureliaKhorsand commented May 13, 2022

Questions for FEC:

  1. What should the Entity type default to? Is it "Organization"? It seems like it only has one option in the specs. Correct.
  2. How are "Donor Committee Name" and "Donor Committee ID" captured? What are these fields referring to? Donor Committee Name will be the same as Organization Name. We should pull in the FEC ID for it if available.

Note that Committee Organization Name can be an Organization OR Committee. Update this and #234. If it is an ORG, then we do not need the ID number. For JF Transfers specifically, it will always be a Committee.

@AureliaKhorsand AureliaKhorsand changed the title Create Group E Transaction Screen Create Group F Transaction Screen (JF Transfers) Jun 7, 2022
@AureliaKhorsand AureliaKhorsand changed the title Create Group F Transaction Screen (JF Transfers) Create Group E Transaction Screen (JF Transfers) Jun 7, 2022
@AureliaKhorsand AureliaKhorsand added the UX/UI attention needed UX/UI tasks and/or redesign needed label Jun 9, 2022
@MitchellTCG
Copy link
Contributor

@AureliaKhorsand
Updated

@MitchellTCG MitchellTCG removed the UX/UI attention needed UX/UI tasks and/or redesign needed label Jun 16, 2022
@MitchellTCG
Copy link
Contributor

I corrected a misspelling of TRANSFER in the orange button

@AureliaKhorsand AureliaKhorsand added the UX/UI attention needed UX/UI tasks and/or redesign needed label Jun 17, 2022
@AureliaKhorsand
Copy link
Contributor Author

@MitchellTCG to update Save & Add JF Transfer Memo button

@MitchellTCG
Copy link
Contributor

@AureliaKhorsand Updated

@MitchellTCG MitchellTCG removed the UX/UI attention needed UX/UI tasks and/or redesign needed label Jun 21, 2022
@mjtravers mjtravers self-assigned this Jun 27, 2022
@mjtravers
Copy link
Contributor

Requesting code changes documented in the PR. Sending back to In Progress

@mjtravers
Copy link
Contributor

Passes CR. There is still an issue with the required text warning not showing up for the date field but this will be addressed in a follow up ticket. Sending to QA

@AureliaKhorsand
Copy link
Contributor Author

@mjtravers do you have the follow-up ticket number that will address the date field required text?

@mjtravers
Copy link
Contributor

@WiseQA
Copy link

WiseQA commented Jul 5, 2022

Returned to in-progress "Date Field" not showing "Required Field". This is broken in this ticket, as it worked in Sprint 9. QA was not aware of any defect being written on this ticket.

@WiseQA
Copy link

WiseQA commented Jul 6, 2022

Note: Wireframe and Acceptance showed:

  • CONTRIBUTOR FEC ID (A/N-10, Required)
    Field description in API: DONOR COMMITTEE FEC ID
    Data field: textbox
    With the ID in the following format: "CXXXXXXXX" where X is a numeric value _(C, then 8 numbers)

After verifying requirements CONTRIBUTOR FEC ID (A/N-10, Required) should be A/N-9.

Changed Acceptance criteria in #233 and #327

@WiseQA
Copy link

WiseQA commented Jul 7, 2022

QA reviewed and verified Group E Transaction Screen using JF Transfers.

Test Case/Test Script attached showing ticket “PASS”.
https://app.zenhub.com/files/306118986/5bf853b7-cd1c-4f4f-ab1f-59667524ab3a/download

QA review completed. Moved to Stage Ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants