Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Group F Transaction Screen (PAC JF Transfer Memo) #327

Closed
AureliaKhorsand opened this issue Jun 7, 2022 · 7 comments
Closed

Create Group F Transaction Screen (PAC JF Transfer Memo) #327

AureliaKhorsand opened this issue Jun 7, 2022 · 7 comments
Assignees

Comments

@AureliaKhorsand
Copy link
Contributor

AureliaKhorsand commented Jun 7, 2022

Business Reason

As a Committee Administrator, I will be able to enter a sub-transaction under "JF Transfers" on Schedule A of a Form 3X report so that I can accurately report on my committee's transactions.

NOTE: This is a "child" transaction that will be associated with a parent transaction.

Acceptance Criteria

Given I am a Committee Administrator

And I am editing a JF Transfer transaction on an open report

Then I will have the option to enter the following sub-transaction:

  • PAC JF Transfer Memo

And I will be required to enter the following information (unless otherwise noted):

  1. Contributor

  • CONTRIBUTOR TYPE (Read-only)

    Field description in API: ENTITY TYPE

    Data field: COMMITTEE

  • CONTRIBUTOR COMMITTEE (A/N-200, Required)

    Field description in API: CONTRIBUTOR ORGANIZATION NAME

    Data field: textbox

  • CONTRIBUTOR FEC ID (A/N-9, Required)

    Field description in API: DONOR COMMITTEE FEC ID

    Data field: textbox

    With the ID in the following format: "CXXXXXXXX" where X is a numeric value (C, then 8 numbers)

    FEC ID IS A STOP-GAP UNTIL THE LOOKUP IS IN PLACE

  1. Address

  • STREET ADDRESS (A/N-34, Required)

    Field description in API: CONTRIBUTOR STREET 1

    Data field: textbox

  • APARTMENT, SUITE, ETC. (A/N-34, Optional)

    Field description in API: CONTRIBUTOR STREET 2

    Data field: textbox

  • CITY (A/N-30, Required)

    Field description in API: CONTRIBUTOR CITY

    Data field: textbox

  • STATE/PROVINCE (ALPHA-2, Required)

    Field description in API: CONTRIBUTOR STATE

    Data field: Dropdown

    Dropdown options: States without military
    https://docs.google.com/spreadsheets/d/17YmnaZgqvFOUyv4-Qknd8ikHe8o9LoDb/edit#gid=494776297

  • ZIP/POSTAL CODE (A/N-9, Required)

    Field description in API: CONTRIBUTOR ZIP

    Data field: textbox

  1. Contribution

  • DATE RECEIVED (NUM-8…YYYYMMDD, Required)

    Field description in API: CONTRIBUTION DATE

    Data field: Date picker

  • MEMO ITEM (A/N-1, Optional)

    Field description in API: MEMO CODE

    Data field: Checkbox

  • CONTRIBUTION AMOUNT (AMT-12, Required)

    Field description in API: CONTRIBUTION AMOUNT

    Data field: textbox

  • CONTRIBUTION AGGREGATE (AMT-12, Required)

    Field description in API: CONTRIBUTION AGGREGATE

    Data field: textbox (FOR NOW it will say $0.00)

  1. Additional information

  • CONTRIBUTION PURPOSE DESCRIPTION (Read-only)

    Field description in API: RECEIPT DESCRIPTION

    Data field: multi-line textbox that must read "JF Memo: XX", where XX is auto-populated with the name of the committee entered in parent transaction JF_TRAN COL SEQ 8

  • NOTE OR MEMO TEXT (A/N-100, Optional)

    Field description in API: MEMO TEXT/DESCRIPTION

    Data field: multi-line textbox

Then I will be able to:

  • "Save & add another JF Transfer Memo" associated to the same "parent"
  • Back to JF Transfer
  • Save & view all transactions [will go to "Manage your transactions" Table]
  • Edit as needed

Dev Note

  • BACK REFERENCE TRAN ID NUMBER (COL_SEQ_5) must populate with Tran ID of the parent transaction. This is required.
  • BACK REFERENCE SCHED NAME (COL_SEQ_6) must populate with Form Type field of the parent transaction. This is required.
  1. See Schedule A spec here.

  2. See spec here.

Group F - PAC JF Transfer Memo.png

Group F - PAC JF Transfer Memo - Errors.png

Group F - PAC JF Transfer Memo - Required Fields.png

QA Notes

null

DEV Notes

null

Design

null

See full ticket and images here: FECFILE-1168

@AureliaKhorsand AureliaKhorsand self-assigned this Jun 7, 2022
@AureliaKhorsand AureliaKhorsand added the UX/UI attention needed UX/UI tasks and/or redesign needed label Jun 7, 2022
@AureliaKhorsand AureliaKhorsand added OP1 and removed UX/UI attention needed UX/UI tasks and/or redesign needed labels Jun 17, 2022
@MitchellTCG MitchellTCG added the UX/UI attention needed UX/UI tasks and/or redesign needed label Jun 17, 2022
@MitchellTCG
Copy link
Contributor

@AureliaKhorsand
Updated

@MitchellTCG MitchellTCG removed the UX/UI attention needed UX/UI tasks and/or redesign needed label Jun 21, 2022
@AureliaKhorsand
Copy link
Contributor Author

Consideration for FEC discussion: If the Parent Transaction name changes after the sub-transaction ticket has been saved, the Contribution Purpose Description note will still display the old name. This is an edge case, but we can prevent this issue a few ways. This is a discussion topic for the 7/5 requirements meeting and not in scope of this ticket.

@mjtravers
Copy link
Contributor

Requested some changes in the fecfile-app and fecfile-validate repos for this ticket. Sending to In Progress

@mjtravers mjtravers self-assigned this Jun 30, 2022
@WiseQA
Copy link

WiseQA commented Jul 5, 2022

Returned to in-progress "Date Field" not showing "Required Field". This is broken in this ticket, as it worked in Sprint 9. QA was not aware of any defect being written on this ticket.

@Elaine-Krauss-TCG
Copy link
Contributor

The date field not showing that it is required is not isolated to this ticket, and correcting this error has its own ticket

https://app.zenhub.com/workspaces/fecfile-online-619e578e68408b001c831251/issues/fecgov/fecfile-web-app/363

@WiseQA
Copy link

WiseQA commented Jul 6, 2022

Note: Wireframe and Acceptance showed:

  • CONTRIBUTOR FEC ID (A/N-10, Required)
    Field description in API: DONOR COMMITTEE FEC ID
    Data field: textbox
    With the ID in the following format: "CXXXXXXXX" where X is a numeric value _(C, then 8 numbers)

After verifying requirements CONTRIBUTOR FEC ID (A/N-10, Required) should be A/N-9.

Changed Acceptance criteria in #233 and #327

@WiseQA
Copy link

WiseQA commented Jul 7, 2022

QA reviewed and verified Group F Transaction Screen using JF Transfers.

Test Case/Test Script attached showing ticket “PASS”.
https://app.zenhub.com/files/306118986/84dea257-4cc7-4e9e-9ac5-3c8b14ef439f/download

QA review completed. Moved to Stage Ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants