Feature/327 create group f transaction screen #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
June 17, 2022 14:45
…=1000(elaine) gid=1001(elaine) groups=1001(elaine),3(sys),10(wheel),964(docker),983(rfkill),987(users) and fields
… and required fields are now highlighted per the schema
…eld appropriately
…working correctly
…reen' into feature/327-create-group-f-transaction-screen
…a chidl transaction
dheitzer
reviewed
Jun 29, 2022
dheitzer
reviewed
Jun 29, 2022
File was added to the commit by accident
…://github.com/fecgov/fecfile-web-app into feature/327-create-group-f-transaction-screen
…://github.com/fecgov/fecfile-web-app into feature/327-create-group-f-transaction-screen
mjtravers
previously requested changes
Jun 30, 2022
front-end/src/app/shared/models/transaction-types/JF_TRAN_PAC_MEMO.model.ts
Show resolved
Hide resolved
mjtravers
reviewed
Jun 30, 2022
front-end/src/app/transactions/transaction-group-e/transaction-group-e.component.html
Outdated
Show resolved
Hide resolved
|
One additional fix from the CR. There is an ANDI issue with not having an accessible name for CONTRIBUTOR FEC ID |
Issue resolved. There was a typo in the |
added 2 commits
June 30, 2022 14:15
|
SonarCloud Quality Gate failed. |
Taken care of! |
dheitzer
approved these changes
Jun 30, 2022
|
Well, I thought that "Close with Comment" was related to the change request that I was replying to... |
mjtravers
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#327
Implements the Group F Transaction screen, allowing the user to create a child transaction for a JF Transfer parent transaction.
#347
Provides additional columns on the View All Transactions screen, allowing the user to view a transaction's id and its parent's id (should it have a parent).
#362
The transaction screens for groups A through F no longer display a "Save & add another" button when the user is editing a transaction rather than creating a new one.
Dependencies