Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulp - fix repofiles to point to pulp #3375

Closed
Tracked by #2533
FrostyX opened this issue Aug 19, 2024 · 2 comments · Fixed by #3383
Closed
Tracked by #2533

Pulp - fix repofiles to point to pulp #3375

FrostyX opened this issue Aug 19, 2024 · 2 comments · Fixed by #3383
Assignees
Labels

Comments

@FrostyX
Copy link
Member

FrostyX commented Aug 19, 2024

No description provided.

@FrostyX FrostyX changed the title fix repofiles to point to pulp Pulp - fix repofiles to point to pulp Aug 19, 2024
@FrostyX FrostyX added the pulp label Aug 19, 2024
@FrostyX
Copy link
Member Author

FrostyX commented Aug 19, 2024

Read this blog post first - https://pavel.raiskup.cz/blog/copr-and-pulp-content-hosting.html

@FrostyX
Copy link
Member Author

FrostyX commented Aug 19, 2024

Warning: DNF4 uses the repofiles from project overview but DNF5 uses API call with all repofiles for the project

@FrostyX FrostyX self-assigned this Aug 21, 2024
FrostyX added a commit to FrostyX/copr that referenced this issue Aug 23, 2024
Fix fedora-copr#3375

Of course only for Copr projects that has configured to have their
storage in Pulp, not all Copr projects.
FrostyX added a commit to FrostyX/copr that referenced this issue Aug 24, 2024
Fix fedora-copr#3375

Of course only for Copr projects that has configured to have their
storage in Pulp, not all Copr projects.

There are three possible options how to implement this.

1. The Most straightforward is to not generate repofiles ourselves and let Pulp
   do it. The downside is that we would have to pass additional parameters (it
   is possible though) such as repo priority, module hotfixes attribute, etc,
   and figure out how to count repo downloads
2. Generate repofiles ourselves, only point to `baseurl` in Pulp. This IMHO the
   best option for keeping compatibility between storage on the backend and in
   Pulp, so I implement this option in this PR.
3. Adding a Lighttpd redirect for `baseurl` of the Pulp-stored projects to Pulp
   content URL. This will be needed in the future to ensure that users don't
   have to re-enable Copr repositories, once those projects are migrated to
   Pulp. But this will be hard to implement, so we decided to do it when the
   time comes.
FrostyX added a commit to FrostyX/dnf5 that referenced this issue Sep 24, 2024
See fedora-copr/copr#3375

When an alternative storage (such as Pulp) for Copr is used, the
pubkey.gpg is still being stored on Copr backend. Therefore we can't
always construct the correct pubkey URL here in the DNF plugin.
FrostyX added a commit to FrostyX/copr that referenced this issue Sep 24, 2024
Fix fedora-copr#3375

Of course only for Copr projects that has configured to have their
storage in Pulp, not all Copr projects.

There are three possible options how to implement this.

1. The Most straightforward is to not generate repofiles ourselves and let Pulp
   do it. The downside is that we would have to pass additional parameters (it
   is possible though) such as repo priority, module hotfixes attribute, etc,
   and figure out how to count repo downloads
2. Generate repofiles ourselves, only point to `baseurl` in Pulp. This IMHO the
   best option for keeping compatibility between storage on the backend and in
   Pulp, so I implement this option in this PR.
3. Adding a Lighttpd redirect for `baseurl` of the Pulp-stored projects to Pulp
   content URL. This will be needed in the future to ensure that users don't
   have to re-enable Copr repositories, once those projects are migrated to
   Pulp. But this will be hard to implement, so we decided to do it when the
   time comes.
FrostyX added a commit to FrostyX/copr that referenced this issue Sep 24, 2024
Fix fedora-copr#3375

Of course only for Copr projects that has configured to have their
storage in Pulp, not all Copr projects.

There are three possible options how to implement this.

1. The Most straightforward is to not generate repofiles ourselves and let Pulp
   do it. The downside is that we would have to pass additional parameters (it
   is possible though) such as repo priority, module hotfixes attribute, etc,
   and figure out how to count repo downloads
2. Generate repofiles ourselves, only point to `baseurl` in Pulp. This IMHO the
   best option for keeping compatibility between storage on the backend and in
   Pulp, so I implement this option in this PR.
3. Adding a Lighttpd redirect for `baseurl` of the Pulp-stored projects to Pulp
   content URL. This will be needed in the future to ensure that users don't
   have to re-enable Copr repositories, once those projects are migrated to
   Pulp. But this will be hard to implement, so we decided to do it when the
   time comes.
FrostyX added a commit to FrostyX/copr that referenced this issue Sep 24, 2024
Fix fedora-copr#3375

Of course only for Copr projects that has configured to have their
storage in Pulp, not all Copr projects.

There are three possible options how to implement this.

1. The Most straightforward is to not generate repofiles ourselves and let Pulp
   do it. The downside is that we would have to pass additional parameters (it
   is possible though) such as repo priority, module hotfixes attribute, etc,
   and figure out how to count repo downloads
2. Generate repofiles ourselves, only point to `baseurl` in Pulp. This IMHO the
   best option for keeping compatibility between storage on the backend and in
   Pulp, so I implement this option in this PR.
3. Adding a Lighttpd redirect for `baseurl` of the Pulp-stored projects to Pulp
   content URL. This will be needed in the future to ensure that users don't
   have to re-enable Copr repositories, once those projects are migrated to
   Pulp. But this will be hard to implement, so we decided to do it when the
   time comes.
github-merge-queue bot pushed a commit to rpm-software-management/dnf5 that referenced this issue Sep 25, 2024
See fedora-copr/copr#3375

When an alternative storage (such as Pulp) for Copr is used, the
pubkey.gpg is still being stored on Copr backend. Therefore we can't
always construct the correct pubkey URL here in the DNF plugin.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant