Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copr: use pubkey URL returned by Copr API #1725

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

FrostyX
Copy link
Member

@FrostyX FrostyX commented Sep 24, 2024

See fedora-copr/copr#3375

When an alternative storage (such as Pulp) for Copr is used, the pubkey.gpg is still being stored on Copr backend. Therefore we can't always construct the correct pubkey URL here in the DNF plugin.

See fedora-copr/copr#3375

When an alternative storage (such as Pulp) for Copr is used, the
pubkey.gpg is still being stored on Copr backend. Therefore we can't
always construct the correct pubkey URL here in the DNF plugin.
@FrostyX
Copy link
Member Author

FrostyX commented Sep 24, 2024

Pinging @praiskup for a review.

@praiskup
Copy link
Member

Thank you!

Copy link
Member

@evan-goode evan-goode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evan-goode evan-goode added this pull request to the merge queue Sep 25, 2024
Merged via the queue into rpm-software-management:main with commit 9d57058 Sep 25, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants