Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hydrated_bloc)!: null safety #2117

Merged
merged 12 commits into from
Jan 31, 2021
Merged

feat(hydrated_bloc)!: null safety #2117

merged 12 commits into from
Jan 31, 2021

Conversation

felangel
Copy link
Owner

@felangel felangel commented Jan 29, 2021 •
edited
Loading

Status

READY

Breaking Changes

YES

Description

  • feat(hydrated_bloc)!: null safety

CHANGES

  • BREAKING: opt into null safety
  • BREAKING: refactor: upgrade to bloc ^7.0.0-nullsafety.1
  • BREAKING: refactor: remove flutter dependency
  • BREAKING: storageDirectory is required when calling HydratedStorage.build
  • BREAKING: HydratedCubit.storage is removed in favor of HydratedBloc.storage
  • feat!: upgrade Dart SDK constraints to >=2.12.0-0 <3.0.0

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel added enhancement New feature or request breaking change Enhancement candidate would introduce a breaking change pkg:hydrated_bloc This issue is related to the hydrated_bloc package labels Jan 29, 2021
@felangel felangel self-assigned this Jan 29, 2021
@felangel felangel marked this pull request as draft January 29, 2021 03:31
@felangel felangel force-pushed the feat/hydrated_bloc-null-safety branch from 290d980 to 203cb84 Compare January 29, 2021 04:58
@codecov
Copy link

codecov bot commented Jan 29, 2021 •
edited
Loading

Codecov Report

Merging #2117 (25680a4) into null_safety (bdb45e4) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           null_safety     #2117    +/-   ##
==============================================
  Coverage       100.00%   100.00%            
==============================================
  Files               14         3    -11     
  Lines              287       158   -129     
==============================================
- Hits               287       158   -129
Impacted Files Coverage Δ
packages/hydrated_bloc/lib/src/hydrated_bloc.dart 100.00% <100.00%> (ø)
...ckages/hydrated_bloc/lib/src/hydrated_storage.dart 100.00% <100.00%> (ø)
packages/bloc/lib/src/bloc.dart
packages/bloc_test/lib/src/bloc_test.dart
packages/bloc_test/lib/src/mock_bloc.dart
packages/bloc/lib/src/bloc_observer.dart
packages/bloc/lib/src/transition.dart
packages/flutter_bloc/lib/src/bloc_listener.dart
...ages/flutter_bloc/lib/src/multi_bloc_provider.dart
packages/flutter_bloc/lib/src/bloc_provider.dart
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdb45e4...25680a4. Read the comment docs.

@felangel felangel mentioned this pull request Jan 29, 2021
Merged
felangel
felangel commented Jan 29, 2021
View reviewed changes
packages/hydrated_bloc/pubspec.yaml Outdated
Comment on lines 18 to 23
dependency_overrides:
hive:
git:
url: https://github.com/hivedb/hive
path: hive
ref: 99ec4d3a180655e550080154abe4f4bd823168aa
Copy link
Owner Author

@felangel felangel Jan 29, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocked by isar/hive#521

@felangel felangel marked this pull request as ready for review January 29, 2021 18:19
@felangel felangel merged commit 2d48777 into null_safety Jan 31, 2021
@felangel felangel deleted the feat/hydrated_bloc-null-safety branch January 31, 2021 03:01
@felangel felangel mentioned this pull request Jan 31, 2021
Merged
17 tasks
felangel added a commit that referenced this pull request Jan 31, 2021
@felangel
feat(hydrated_bloc)!: null safety (#2117)
235920c
felangel added a commit that referenced this pull request Jan 31, 2021
@felangel
feat(hydrated_bloc)!: null safety (#2117)
eaee9a5
felangel added a commit that referenced this pull request Feb 6, 2021
@felangel
feat(hydrated_bloc)!: null safety (#2117)
10bb00a
felangel added a commit that referenced this pull request Feb 8, 2021
@felangel
feat(hydrated_bloc)!: null safety (#2117)
73e51c5
felangel added a commit that referenced this pull request Feb 11, 2021
@felangel
feat(hydrated_bloc)!: null safety (#2117)
2ae97d0
felangel added a commit that referenced this pull request Feb 14, 2021
@felangel
feat(hydrated_bloc)!: null safety (#2117)
d9bdf7a
felangel added a commit that referenced this pull request Mar 3, 2021
@felangel
feat(hydrated_bloc)!: null safety (#2117)
a7ae7a5
felangel added a commit that referenced this pull request Mar 4, 2021
@felangel
feat(hydrated_bloc)!: null safety (#2117)
eb47efb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgecoca jorgecoca Awaiting requested review from jorgecoca

Assignees

@felangel felangel

Labels
breaking change Enhancement candidate would introduce a breaking change enhancement New feature or request pkg:hydrated_bloc This issue is related to the hydrated_bloc package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@felangel