Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: null safety #1733

Merged
merged 42 commits into from
Mar 4, 2021
Merged

feat!: null safety #1733

merged 42 commits into from
Mar 4, 2021

Conversation

felangel
Copy link
Owner

@felangel felangel commented Sep 16, 2020 •
edited
Loading

Status

IN DEVELOPMENT

Breaking Changes

YES

Description

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel added pkg:bloc This issue is related to the bloc package breaking change Enhancement candidate would introduce a breaking change labels Sep 16, 2020
@felangel felangel self-assigned this Sep 16, 2020
jakemac53
jakemac53 reviewed Sep 16, 2020
View reviewed changes
Copy link
Contributor

@jakemac53 jakemac53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 👍

packages/bloc/pubspec.yaml Show resolved Hide resolved
packages/bloc/pubspec.yaml Outdated Show resolved Hide resolved
Jomik
Jomik reviewed Oct 2, 2020
View reviewed changes
packages/bloc/lib/src/bloc.dart Outdated Show resolved Hide resolved
packages/bloc/lib/src/bloc.dart Show resolved Hide resolved
jakemac53
jakemac53 reviewed Oct 2, 2020
View reviewed changes
Copy link
Contributor

@jakemac53 jakemac53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, my main feedback would be around the nullable StackTrace arguments which I think should be non-nullable.

packages/bloc/example/main.dart Outdated Show resolved Hide resolved
packages/bloc/lib/src/cubit.dart Outdated Show resolved Hide resolved
packages/bloc/lib/src/cubit.dart Outdated Show resolved Hide resolved
packages/bloc/pubspec.yaml Outdated Show resolved Hide resolved
packages/bloc/pubspec.yaml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 7, 2020 •
edited
Loading

Codecov Report

Merging #1733 (1a19ab7) into master (c5439b1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master     #1733    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           17        17            
  Lines          307       440   +133     
==========================================
+ Hits           307       440   +133
Impacted Files Coverage Δ
packages/bloc/lib/src/bloc_observer.dart 100.00% <ø> (ø)
packages/bloc/lib/src/transition.dart 100.00% <ø> (ø)
...ages/flutter_bloc/lib/src/repository_provider.dart 100.00% <ø> (ø)
packages/bloc/lib/src/bloc.dart 100.00% <100.00%> (ø)
packages/bloc_test/lib/src/bloc_test.dart 100.00% <100.00%> (ø)
packages/bloc_test/lib/src/mock_bloc.dart 100.00% <100.00%> (ø)
packages/bloc_test/lib/src/when_listen.dart 100.00% <100.00%> (ø)
packages/flutter_bloc/lib/src/bloc_builder.dart 100.00% <100.00%> (ø)
packages/flutter_bloc/lib/src/bloc_consumer.dart 100.00% <100.00%> (ø)
packages/flutter_bloc/lib/src/bloc_listener.dart 100.00% <100.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5439b1...1a19ab7. Read the comment docs.

diegoflassa
diegoflassa previously approved these changes Nov 7, 2020
View reviewed changes
@felangel felangel force-pushed the null_safety branch 4 times, most recently from d181165 to dadd44d Compare November 22, 2020 06:07
@felangel
Copy link
Owner Author

Published bloc v7.0.0-nullsafety.0 🎉

@felangel felangel linked an issue Nov 23, 2020 that may be closed by this pull request
Null-Safety #1932
Closed
@felangel felangel force-pushed the null_safety branch 2 times, most recently from e897a2c to 3afd0c5 Compare December 13, 2020 23:29
@felangel felangel changed the title feat(bloc)!: nullsafety feat!: nullsafety Dec 13, 2020
@felangel
Copy link
Owner Author

Published flutter_bloc v7.0.0-nullsafety.0 🎉

@felangel felangel added the pkg:flutter_bloc This issue is related to the flutter_bloc package label Dec 21, 2020
@felangel felangel added pkg:angular_bloc This issue is related to the angular_bloc package pkg:bloc_test This issue is related to the bloc_test package labels Jan 13, 2021
@felangel felangel linked an issue Jan 13, 2021 that may be closed by this pull request
Release a null-safe pre-release of bloc_test #2063
Closed
@felangel
Copy link
Owner Author

felangel commented Mar 3, 2021

Published bloc v7.0.0-nullsafety.3 🎉

@felangel felangel force-pushed the null_safety branch 2 times, most recently from 72a5e83 to 3a9bd45 Compare March 3, 2021 19:56
@felangel
Copy link
Owner Author

felangel commented Mar 3, 2021

Published bloc_test v8.0.0-nullsafety.1 🎉

@felangel
Copy link
Owner Author

felangel commented Mar 3, 2021

Published flutter_bloc v7.0.0-nullsafety.3 🎉

@felangel
Copy link
Owner Author

felangel commented Mar 3, 2021

Published hydrated_bloc v7.0.0-nullsafety.2 🎉

@felangel
Copy link
Owner Author

felangel commented Mar 3, 2021

Published replay_bloc v0.0.1-nullsafety.2 🎉

@felangel felangel marked this pull request as ready for review March 4, 2021 17:56
@felangel
Copy link
Owner Author

felangel commented Mar 4, 2021

Finally time to merge this 🎉

I'm going to hold off on publishing a stable release for a bit longer in order to get a few more issues included but should hopefully have a stable release in the next week 👍

@felangel felangel merged commit b2ca768 into master Mar 4, 2021
@felangel felangel deleted the null_safety branch March 4, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jomik Jomik Jomik left review comments

@jakemac53 jakemac53 jakemac53 left review comments

@eernstg eernstg eernstg left review comments

@diegoflassa diegoflassa diegoflassa left review comments

@jorgecoca jorgecoca Awaiting requested review from jorgecoca

Assignees

@felangel felangel

Labels
breaking change Enhancement candidate would introduce a breaking change example Example application pkg:angular_bloc This issue is related to the angular_bloc package pkg:bloc_test This issue is related to the bloc_test package pkg:bloc This issue is related to the bloc package pkg:flutter_bloc This issue is related to the flutter_bloc package pkg:hydrated_bloc This issue is related to the hydrated_bloc package pkg:replay_bloc This issue is related to the replay_bloc package release candidate Candidate for release pending successful build
Projects
None yet
Milestone
No milestone
8 participants
@felangel @zepfietje @Jomik @jakemac53 @diegoflassa @eernstg @Abhishek01039 @PlugFox