-
-
Notifications
You must be signed in to change notification settings - Fork 851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Proof of concept to let ffmpeg.wasm work in angular #562
[WIP] Proof of concept to let ffmpeg.wasm work in angular #562
Conversation
✅ Deploy Preview for ffmpegwasm canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve this
I would love to have this merged |
same here... |
for what it's worth. if you need this as a quickfix in javascript, edit vanilla-app/public/assets/ffmpeg/package/dist/umd/ffmpeg.js to have the load method look like this:
then give a
|
Hi guys, any news about this solution? |
Fixed by #652 |
Hi @jeromewu , why did you create you own pull request instead of contributing to this one ? (I'm just curious) |
@ayoubqrt Sorry about that, there was another PR (#639) fixing the same issue and I tried to fix it with my own PR (#652) as I am not sure if the author will respond to my comments soon. And later I found this PR is actually doing the same fix (The name was misleading, so I am not aware of that in the first place). I have no intention to redo the work here. |
Okay no problem at all @jeromewu . Thank you for the clarification. I think it would have been nice anyway to wait his answer but I understand that it can be frustrating as you want to ship the fix. Have a nice day ! |
@jeromewu tested here and it don't worked. |
Attempt to fix #560 and #548
I am not a web developer and am not familiar with the tools to compile or test this locally. If someone could point me in the direction of some tutorials / docs on that I can test this in an angular app.