Add option to pass worker url to the ffmpeg.load #639
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ffmpegwasm canceled.
|
|
🥳 |
|
@kisel4363 I think this PR doesn't make sense as the Can you share more context of your use case here? |
Merged
|
Hey @jeromewu. Here's the issue I opened in the Remix repo. Not sure if this is a Remix issue or an ffmpeg/WASM issue. Would you be able to take a look at the reproduction repo I created (linked in the above issue)... I'm kinda stuck. |
|
I have no experience in remix and thus don't know how to help. You can try 0.12.8 and see if assigning a custom classWorkerURL helps. |
|
@jeromewu The fix from #652 does not seem to be in the ESM module for 0.12.8: |
|
@dchristensen Fixed in 0.12.9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.