FIP-0094: Add Support for EIP-5656 (MCOPY Opcode) in the FEVM #1047
Conversation
snissn
requested review from
momack2,
arajasek,
jennijuju,
kaitlin-beegle,
anorth,
raulk,
jsoares and
TippyFlitsUK
as code owners
FIPS/fip-mcopy-opcode-fevm.md
Outdated
| A series of test cases will be provided to ensure that the `MCOPY` opcode functions as expected under various scenarios. These test cases will include non-overlapping memory copy, overlapping memory copy, out-of-bounds source handling, and memory expansion. | ||
|
|
||
| ## Security Considerations | ||
| Security implications for the `MCOPY` opcode are similar to other memory manipulation operations. Special care will be taken to ensure that overlapping memory regions are handled safely, preventing data corruption. Additionally, the implementation will include checks to prevent out-of-bounds memory access, which could otherwise lead to unexpected behavior or security vulnerabilities. |
There was a problem hiding this comment.
Special care will be taken to ensure that overlapping memory regions are handled safely, preventing data corruption.
could you please elaborate on "the special care" that is taken to ensure the proper handling of memory region overlap?
There was a problem hiding this comment.
Sure - the the spec is clear that if we copy one region to another and they overlap it should work as if you take a copy of the source region and paste it over the destination region without any errors or bugs due to over-writes as if you had created a unique copy of the memory being copied before the write. The original EIP describes it as: Copying takes place as if an intermediate buffer was used, allowing the destination and source to overlap. in the built in actors implementation we use the slice built in method copy_within which accounts for that issue.
|
@snissn thanks for the FIP! This draft proposes a straightforward fevm enhancement and is well-written! I have some small nits otherwise it LGTM |
jennijuju
changed the title
|
Thanks @jennijuju I was able to update the PR with your suggestions. Please review the response that I hope resolves your question about |
| @@ -129,3 +129,4 @@ This improvement protocol helps achieve that objective for all members of the Fi | |||
| | [0090](https://github.com/filecoin-project/FIPs/blob/master/FIPS/fip-0090.md) | Non-Interactive PoRep | FIP | luca (@lucaniz), kuba (@Kubuxu), nicola (@nicola), nemo (@cryptonemo), volker (@vmx), irene (@irenegia) | Superseded by [FIP0092](https://github.com/filecoin-project/FIPs/blob/master/FIPS/fip-0092.md) | | |||
| | [0091](https://github.com/filecoin-project/FIPs/blob/master/FIPS/fip-0091.md) | Add support for Homestead and EIP-155 Ethereum Transactions ("legacy" Ethereum Transactions) | FIP | Aarsh (@aarshkshah1992)| Accepted | | |||
| | [0092](https://github.com/filecoin-project/FIPs/blob/master/FIPS/fip-0092.md) | Non-Interactive PoRep | FIP | luca (@lucaniz), kuba (@Kubuxu), nicola (@nicola), nemo (@cryptonemo), volker (@vmx), irene (@irenegia), Alex North (@anorth), orjan (@Phi-rjan) | Final | | |||
| | [XXXX](https://github.com/filecoin-project/FIPs/blob/master/FIPS/fip-mcopy-opcode-fevm.md) | Add Support for EIP-5656 (MCOPY Opcode) in the FEVM | FIP | Michael Seiler (@snissn), Raúl Kripalani (@raulk), Steven Allen (@stebalien) | Draft | | |||
There was a problem hiding this comment.
| | [XXXX](https://github.com/filecoin-project/FIPs/blob/master/FIPS/fip-mcopy-opcode-fevm.md) | Add Support for EIP-5656 (MCOPY Opcode) in the FEVM | FIP | Michael Seiler (@snissn), Raúl Kripalani (@raulk), Steven Allen (@stebalien) | Draft | | |
| | [0094](https://github.com/filecoin-project/FIPs/blob/master/FIPS/fip-mcopy-opcode-fevm.md) | Add Support for EIP-5656 (MCOPY Opcode) in the FEVM | FIP | Michael Seiler (@snissn), Raúl Kripalani (@raulk), Steven Allen (@stebalien) | Draft | |
The
MCOPYopcode provides a more efficient mechanism for memory copying within smart contracts. This proposal suggests integratingMCOPYinto the FEVM, ensuring compatibility with Solidity versions v0.8.25 and later, which rely on this opcode for certain operations.#1025