Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIP-0094: Add Support for EIP-5656 (MCOPY Opcode) in the FEVM #1047
FIP-0094: Add Support for EIP-5656 (MCOPY Opcode) in the FEVM #1047
Changes from 3 commits
69e5236
f195be9
47471fb
8127af7
8c6e885
0d7471f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please elaborate on "the special care" that is taken to ensure the proper handling of memory region overlap?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure - the the spec is clear that if we copy one region to another and they overlap it should work as if you take a copy of the source region and paste it over the destination region without any errors or bugs due to over-writes as if you had created a unique copy of the memory being copied before the write. The original EIP describes it as:
Copying takes place as if an intermediate buffer was used, allowing the destination and source to overlap.
in the built in actors implementation we use the slice built in method copy_within which accounts for that issue.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.